Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runaway: change QUERY WATCH time type to UTC #56015

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Sep 11, 2024

What problem does this PR solve?

before

When using QUERY WATCH ADD RESOURCE GROUP default SQL TEXT EXACT TO 'select * from sbtest.sbtest1'; will add local time

mysql> SELECT * FROM INFORMATION_SCHEMA.RUNAWAY_WATCHES ORDER BY id\G
*************************** 1. row ***************************
                 ID: 1
RESOURCE_GROUP_NAME: default
         START_TIME: 2024-09-11 07:38:09
           END_TIME: 2024-09-11 07:48:09
              WATCH: Exact
         WATCH_TEXT: select sleep(2) from t
             SOURCE: 127.0.0.1:4000
             ACTION: Kill
*************************** 2. row ***************************
                 ID: 2
RESOURCE_GROUP_NAME: default
         START_TIME: 2024-09-11 15:38:20
           END_TIME: UNLIMITED
              WATCH: Exact
         WATCH_TEXT: select * from sbtest.sbtest1
             SOURCE: manual
             ACTION: Kill
2 rows in set (0.00 sec)

After

mysql> SELECT * FROM INFORMATION_SCHEMA.RUNAWAY_WATCHES ORDER BY id\G
*************************** 1. row ***************************
                 ID: 1
RESOURCE_GROUP_NAME: default
         START_TIME: 2024-09-11 07:41:55
           END_TIME: 2024-09-11 07:51:55
              WATCH: Exact
         WATCH_TEXT: select sleep(2) from t
             SOURCE: 127.0.0.1:4000
             ACTION: Kill
*************************** 2. row ***************************
                 ID: 2
RESOURCE_GROUP_NAME: default
         START_TIME: 2024-09-11 07:42:02
           END_TIME: UNLIMITED
              WATCH: Exact
         WATCH_TEXT: select * from sbtest.sbtest1
             SOURCE: manual
             ACTION: Kill

Issue Number: close #54770

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: husharp <ihusharp@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2024
Copy link

tiprow bot commented Sep 11, 2024

Hi @HuSharp. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.2926%. Comparing base (2ea3542) to head (0414ea5).
Report is 11 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56015         +/-   ##
=================================================
- Coverage   72.8732%   56.2926%   -16.5807%     
=================================================
  Files          1605       1730        +125     
  Lines        446555     623073     +176518     
=================================================
+ Hits         325419     350744      +25325     
- Misses       101082     248581     +147499     
- Partials      20054      23748       +3694     
Flag Coverage Δ
integration 37.4530% <0.0000%> (?)
unit 72.2076% <100.0000%> (+0.2175%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.8437% <ø> (+7.0894%) ⬆️

@glorv glorv added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Sep 11, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 12, 2024
@nolouch
Copy link
Member

nolouch commented Sep 12, 2024

cc @glorv

Copy link

ti-chi-bot bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 12, 2024
Copy link

ti-chi-bot bot commented Sep 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-12 06:58:37.931372463 +0000 UTC m=+512387.671796402: ☑️ agreed by nolouch.
  • 2024-09-12 07:43:15.015099786 +0000 UTC m=+515064.755523725: ☑️ agreed by glorv.

@ti-chi-bot ti-chi-bot bot merged commit 1dc045f into pingcap:master Sep 12, 2024
23 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 12, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #56042.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #56043.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 12, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@HuSharp HuSharp deleted the unify_runaway_time2 branch September 12, 2024 08:28
ti-chi-bot bot pushed a commit that referenced this pull request Sep 23, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runaway: change RUNAWAY_WATCHES time type to UTC
4 participants