Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: args v2 for add/drop index/primary key #56130

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

joechenrh
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #53930

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 18, 2024
Copy link

ti-chi-bot bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 3pointer, tangenta for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 18, 2024
Copy link

tiprow bot commented Sep 18, 2024

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 72 lines in your changes missing coverage. Please review.

Project coverage is 74.6368%. Comparing base (66d8cdc) to head (dc1642c).
Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56130        +/-   ##
================================================
+ Coverage   72.9612%   74.6368%   +1.6755%     
================================================
  Files          1611       1654        +43     
  Lines        447632     457431      +9799     
================================================
+ Hits         326598     341412     +14814     
+ Misses       101001      94488      -6513     
- Partials      20033      21531      +1498     
Flag Coverage Δ
integration 47.2347% <60.0000%> (?)
unit 72.5180% <84.0000%> (+0.4776%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 62.1352% <60.0000%> (+16.2591%) ⬆️

@joechenrh joechenrh force-pushed the addargs-indexes branch 2 times, most recently from 803f379 to dc1642c Compare September 20, 2024 05:50
Copy link

ti-chi-bot bot commented Sep 20, 2024

@joechenrh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build dc1642c link true /test build
idc-jenkins-ci-tidb/check_dev dc1642c link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 dc1642c link true /test check-dev2
idc-jenkins-ci-tidb/mysql-test dc1642c link true /test mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant