Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: fix sub_part in information_schema.statistics table｜tidb-test=pr/2400 #56208

Merged
merged 3 commits into from
Sep 23, 2024
Merged

infoschema: fix sub_part in information_schema.statistics table｜tidb-test=pr/2400 #56208

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6dc6b0
This is an automated cherry-pick of #55814
Defined2014 Sep 3, 2024
6c150c3
Delete tests/integrationtest/r/executor/infoschema_reader.result
Defined2014 Sep 23, 2024
789aa3e
Delete tests/integrationtest/t/executor/infoschema_reader.test
Defined2014 Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/executor/infoschema_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,11 @@ func (e *memtableRetriever) setDataForStatisticsInTable(schema *model.DBInfo, ta
expression = tblCol.GeneratedExprString
}

var subPart any
if key.Length != types.UnspecifiedLength {
subPart = key.Length
}

record := types.MakeDatums(
infoschema.CatalogVal, // TABLE_CATALOG
schema.Name.O, // TABLE_SCHEMA
Expand All @@ -439,7 +444,7 @@ func (e *memtableRetriever) setDataForStatisticsInTable(schema *model.DBInfo, ta
colName, // COLUMN_NAME
"A", // COLLATION
0, // CARDINALITY
nil, // SUB_PART
subPart, // SUB_PART
nil, // PACKED
nullable, // NULLABLE
"BTREE", // INDEX_TYPE
Expand Down