ddl_notifier: publish schema change event to store by `asyncNotifyEvent` #56425

fzzf678 · 2024-09-30T09:06:23Z

What problem does this PR solve?

Issue Number: ref #55722

Problem Summary:

What changed and how does it work?

Publish schema change event in asyncNotifyEvent. We need sessionctx.Context to operate system table(not created yet)，so we made some functions became woker's method

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

find a init place

ti-chi-bot · 2024-09-30T09:06:27Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tiprow · 2024-09-30T09:06:42Z

Hi @fzzf678. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-10-10T08:33:40Z

Codecov Report

Attention: Patch coverage is 52.63158% with 63 lines in your changes missing coverage. Please review.

Project coverage is 57.1632%. Comparing base (ff317ee) to head (8f90ddd).
Report is 4 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56425         +/-   ##
=================================================
- Coverage   73.3335%   57.1632%   -16.1704%     
=================================================
  Files          1629       1779        +150     
  Lines        450157     637877     +187720     
=================================================
+ Hits         330116     364631      +34515     
- Misses        99787     248283     +148496     
- Partials      20254      24963       +4709

Flag	Coverage Δ
integration	`39.2396% <40.6015%> (?)`
unit	`72.7093% <49.6240%> (+0.2521%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9478% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`63.2913% <ø> (+17.7185%)`	⬆️

pkg/ddl/ddl.go

fzzf678 · 2024-10-10T12:55:02Z

/retest

tiprow · 2024-10-10T12:55:27Z

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pkg/ddl/ddl.go

pkg/ddl/notifier/testkit_test.go

lance6716

~~rest lgtm~~

pkg/ddl/ddl.go

ti-chi-bot · 2024-10-15T07:22:16Z

@fzzf678: GitHub didn't allow me to request PR reviews from the following users: a, look, at, this, please, also, take.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Rustin170506 @time-and-fate @winoros please also take a look at this commit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

time-and-fate

/hold
Feel free to /unhold it if you are ready to merge it.

ti-chi-bot · 2024-10-16T22:14:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/ddl/OWNERS~~ [lance6716]
~~pkg/statistics/OWNERS~~ [time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-10-16T22:14:23Z

[LGTM Timeline notifier]

Timeline:

2024-10-14 02:20:14.059683352 +0000 UTC m=+237611.208593177: ✖️🔁 reset by lance6716.
2024-10-15 07:19:04.232088394 +0000 UTC m=+341941.380998223: ☑️ agreed by lance6716.
2024-10-16 22:14:22.466189914 +0000 UTC m=+482059.615099745: ☑️ agreed by time-and-fate.

pkg/ddl/notifier/events.go

Co-authored-by: Zhou Kunqin <25057648+time-and-fate@users.noreply.github.com>

fzzf678 · 2024-10-17T04:09:59Z

/retest

fzzf678 · 2024-10-17T04:10:05Z

/unhold

tiprow · 2024-10-17T04:10:31Z

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fzzf678 · 2024-10-17T04:38:30Z

/retest

tiprow · 2024-10-17T04:38:52Z

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fzzf678 · 2024-10-17T04:59:02Z

/retest

tiprow · 2024-10-17T04:59:24Z

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fzzf678 · 2024-10-17T06:02:06Z

/retest

tiprow · 2024-10-17T06:02:28Z

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fzzf678 added 4 commits September 26, 2024 17:19

add arg

95d99de

pass session pool to notifier

9b56303

find a init place

add test

cdfe70d

add test

222fc3a

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2024

fzzf678 added 2 commits September 30, 2024 17:12

Merge remote-tracking branch 'upstream/master' into start&stop_notifier

434d732

skip sys table event

9f0af16

fzzf678 marked this pull request as ready for review October 10, 2024 08:14

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2024

fzzf678 added 2 commits October 10, 2024 16:21

Merge remote-tracking branch 'upstream/master' into start&stop_notifier

534cedf

update bazel fix nogo

92ee134

lance6716 reviewed Oct 10, 2024

View reviewed changes

pkg/ddl/ddl.go Outdated Show resolved Hide resolved

use the same session of worker

cdecc96

fzzf678 commented Oct 10, 2024

View reviewed changes

pkg/ddl/ddl.go Outdated Show resolved Hide resolved

pass multi schema change seq

3cb0bcc

fzzf678 commented Oct 11, 2024

View reviewed changes

pkg/ddl/ddl.go Outdated Show resolved Hide resolved

fzzf678 added 3 commits October 11, 2024 15:43

fail the publish invoker

6278ceb

add test

b141153

update bazel

9de19c3

lance6716 reviewed Oct 11, 2024

View reviewed changes

pkg/ddl/ddl.go Outdated Show resolved Hide resolved

pkg/ddl/ddl.go Show resolved Hide resolved

pkg/ddl/notifier/testkit_test.go Outdated Show resolved Hide resolved

fzzf678 added 2 commits October 12, 2024 14:38

use sess.Session

4e72686

Merge remote-tracking branch 'upstream/master' into start&stop_notifier

6a2e374

lance6716 reviewed Oct 14, 2024

View reviewed changes

pkg/ddl/ddl.go Show resolved Hide resolved

pkg/ddl/ddl.go Outdated Show resolved Hide resolved

ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 15, 2024

Update testkit_test.go

faa4526

lance6716 approved these changes Oct 15, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 15, 2024

ti-chi-bot bot requested review from time-and-fate, winoros and Rustin170506 October 15, 2024 07:22

time-and-fate approved these changes Oct 16, 2024

View reviewed changes

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2024

ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2024

time-and-fate reviewed Oct 16, 2024

View reviewed changes

pkg/ddl/notifier/events.go Outdated Show resolved Hide resolved

fzzf678 and others added 3 commits October 17, 2024 10:04

Update pkg/ddl/notifier/events.go

5779acf

Co-authored-by: Zhou Kunqin <25057648+time-and-fate@users.noreply.github.com>

Merge remote-tracking branch 'upstream/master' into start&stop_notifier

dbb7b5f

Update modify_column.go

8f90ddd

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2024

ti-chi-bot bot merged commit 1e76e6e into pingcap:master Oct 17, 2024
24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddl_notifier: publish schema change event to store by `asyncNotifyEvent` #56425

ddl_notifier: publish schema change event to store by `asyncNotifyEvent` #56425

fzzf678 commented Sep 30, 2024 •

edited

Loading

ti-chi-bot bot commented Sep 30, 2024

tiprow bot commented Sep 30, 2024

codecov bot commented Oct 10, 2024 •

edited

Loading

fzzf678 commented Oct 10, 2024

tiprow bot commented Oct 10, 2024

lance6716 left a comment •

edited

Loading

ti-chi-bot bot commented Oct 15, 2024

time-and-fate left a comment

ti-chi-bot bot commented Oct 16, 2024

ti-chi-bot bot commented Oct 16, 2024

fzzf678 commented Oct 17, 2024

fzzf678 commented Oct 17, 2024

tiprow bot commented Oct 17, 2024

fzzf678 commented Oct 17, 2024

tiprow bot commented Oct 17, 2024

fzzf678 commented Oct 17, 2024

tiprow bot commented Oct 17, 2024

fzzf678 commented Oct 17, 2024

tiprow bot commented Oct 17, 2024

ddl_notifier: publish schema change event to store by asyncNotifyEvent #56425

ddl_notifier: publish schema change event to store by asyncNotifyEvent #56425

Conversation

fzzf678 commented Sep 30, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Sep 30, 2024

tiprow bot commented Sep 30, 2024

codecov bot commented Oct 10, 2024 • edited Loading

Codecov Report

fzzf678 commented Oct 10, 2024

tiprow bot commented Oct 10, 2024

lance6716 left a comment • edited Loading

Choose a reason for hiding this comment

ti-chi-bot bot commented Oct 15, 2024

time-and-fate left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Oct 16, 2024

ti-chi-bot bot commented Oct 16, 2024

[LGTM Timeline notifier]

fzzf678 commented Oct 17, 2024

fzzf678 commented Oct 17, 2024

tiprow bot commented Oct 17, 2024

fzzf678 commented Oct 17, 2024

tiprow bot commented Oct 17, 2024

fzzf678 commented Oct 17, 2024

tiprow bot commented Oct 17, 2024

fzzf678 commented Oct 17, 2024

tiprow bot commented Oct 17, 2024

ddl_notifier: publish schema change event to store by `asyncNotifyEvent` #56425

ddl_notifier: publish schema change event to store by `asyncNotifyEvent` #56425

fzzf678 commented Sep 30, 2024 •

edited

Loading

codecov bot commented Oct 10, 2024 •

edited

Loading

lance6716 left a comment •

edited

Loading