-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: make default_authentication_plugin
more compatible with mysql
#56660
Conversation
Skipping CI for Draft Pull Request. |
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56660 +/- ##
=================================================
- Coverage 73.3500% 56.5109% -16.8391%
=================================================
Files 1629 1756 +127
Lines 450090 635992 +185902
=================================================
+ Hits 330141 359405 +29264
- Misses 99710 252459 +152749
- Partials 20239 24128 +3889
Flags with carried forward coverage won't be shown. Click here to find out more.
|
default_authentication_plugin
more compatible with mysqldefault_authentication_plugin
more compatible with mysql
61a65b0
to
21b7e93
Compare
|
||
connection default; | ||
set global default_authentication_plugin = 'caching_sha2_password'; | ||
create user default_sha256_user; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the sha256
is confusing here as there used to be a sha256_password
plugin.
create user default_sha256_user; | |
create user default_sha2_user; |
(more modifications needed if you merge this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in fa4a9a1
# TestDefaultAuthPluginForCreateUser | ||
|
||
connection default; | ||
set global default_authentication_plugin = 'caching_sha2_password'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add something like set global default_authentication_plugin = 'xxxxx'
to test the validation of the plugin name?
Maybe add statements like CREATE USER ... IDENTIFIED WITH ...
to test if you can still create users with mysql_native_plugin
when the default_authentication_plugin
is set to caching_sha2_password
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in fa4a9a1
/retest |
@CbcWestwolf: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dveeden, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #54138
Problem Summary:
See the issue decription
What changed and how does it work?
Get default auth plugin when creating, altering and granting user.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.