Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/integrationtest2: fix bugs in the tests #56815

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Oct 24, 2024

What problem does this PR solve?

Issue Number: ref #56556

Problem Summary:

What changed and how does it work?

Fix some bugs introduced in #56486

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • NA

Documentation

  • NA

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 24, 2024
@bb7133 bb7133 added the type/enhancement The issue or PR belongs to an enhancement. label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.7516%. Comparing base (ed9a909) to head (bffe3fc).
Report is 5 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56815         +/-   ##
=================================================
- Coverage   73.2825%   56.7516%   -16.5310%     
=================================================
  Files          1636       1761        +125     
  Lines        453340     635820     +182480     
=================================================
+ Hits         332219     360838      +28619     
- Misses       100768     250892     +150124     
- Partials      20353      24090       +3737     
Flag Coverage Δ
integration 37.4640% <ø> (?)
unit 73.0037% <ø> (+0.5181%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.6986% <ø> (+6.7074%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 25, 2024
Copy link

ti-chi-bot bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 25, 2024
Copy link

ti-chi-bot bot commented Oct 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-25 02:12:59.168512662 +0000 UTC m=+576379.865303280: ☑️ agreed by hawkingrei.
  • 2024-10-25 06:32:51.888357771 +0000 UTC m=+591972.585148380: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 7ce5bd7 into pingcap:master Oct 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants