Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: use maximum length for integer display (#56463) #56929

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56463

What problem does this PR solve?

Issue Number: close #56462 close #45338 close #41719

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Issues related to casting integers with a non-default display width to strings have been fixed.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added found/gs found by gs ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Oct 29, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@e62cfd5). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #56929   +/-   ##
================================================
  Coverage               ?   72.1457%           
================================================
  Files                  ?       1415           
  Lines                  ?     412785           
  Branches               ?          0           
================================================
  Hits                   ?     297807           
  Misses                 ?      94996           
  Partials               ?      19982           
Flag Coverage Δ
unit 72.1457% <77.7777%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5113% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 2, 2024
@dveeden
Copy link
Contributor

dveeden commented Dec 2, 2024

Looks like expression/issues might have issues in release-7.5 even without this PR

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 2, 2024
@lance6716
Copy link
Contributor

@dveeden I think you should ask a expression package code owner https://github.com/pingcap/tidb/blob/release-7.5/OWNERS_ALIASES#L34 to triage this cherry-pick, to remove "do-not-merge/cherry-pick-not-approved" label

@dveeden
Copy link
Contributor

dveeden commented Dec 2, 2024

/retest

1 similar comment
@dveeden
Copy link
Contributor

dveeden commented Dec 2, 2024

/retest

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 3, 2024
@dveeden dveeden requested a review from windtalker December 3, 2024 06:14
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

ti-chi-bot bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 3, 2024
Copy link

ti-chi-bot bot commented Dec 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-02 11:14:17.456592104 +0000 UTC m=+1067045.076246619: ☑️ agreed by lance6716.
  • 2024-12-03 06:33:34.437272411 +0000 UTC m=+1136602.056926927: ☑️ agreed by windtalker.

@dveeden
Copy link
Contributor

dveeden commented Dec 3, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit bf0766b into pingcap:release-7.5 Dec 3, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. found/gs found by gs lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants