Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: let resource group selector take effect to all panels (#56573) #56933

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Oct 29, 2024

This is an automated cherry-pick of #56573

NOTE: This PR cherry picks #56320, #56374, #56548, #56573 to let v8.1 also support using jsonnet to generate grafana config file.

The granana page config for v8.1 is almost identical with v8.4(current master), with only 2 panels deleted because v8.1 does not support:

  • Resource Unit/ RU Config
  • Background Task Control / Background Task Resource Utilization

What problem does this PR solve?

Issue Number: close #56572

Problem Summary:

What changed and how does it work?

default:
image

Select 1 resource group:

image

Select multiple groups:

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Oct 29, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cherry-pick-approved Cherry pick PR approved by release team. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved labels Oct 29, 2024
@glorv glorv force-pushed the cherry-pick-56573-to-release-8.1 branch from 99ecbf6 to 4d9035c Compare October 29, 2024 04:28
@glorv glorv requested a review from nolouch October 29, 2024 04:34
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@3c16157). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #56933   +/-   ##
================================================
  Coverage               ?   71.2663%           
================================================
  Files                  ?       1466           
  Lines                  ?     423441           
  Branches               ?          0           
================================================
  Hits                   ?     301771           
  Misses                 ?     101216           
  Partials               ?      20454           
Flag Coverage Δ
unit 71.2663% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.3155% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 29, 2024
@nolouch nolouch requested a review from JmPotato October 29, 2024 06:19
Copy link

ti-chi-bot bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 30, 2024
Copy link

ti-chi-bot bot commented Oct 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-29 06:09:23.777293683 +0000 UTC m=+330076.616449222: ☑️ agreed by nolouch.
  • 2024-10-30 07:59:03.413041877 +0000 UTC m=+423056.252197421: ☑️ agreed by glorv.

@glorv
Copy link
Contributor

glorv commented Oct 30, 2024

/retest

1 similar comment
@glorv
Copy link
Contributor

glorv commented Oct 30, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 561dd71 into pingcap:release-8.1 Oct 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants