-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: make chunk.SwapColumn
private (#57274)
#57373
*: make chunk.SwapColumn
private (#57274)
#57373
Conversation
2f45eef
to
3f58b0b
Compare
/test unit-test |
@windtalker: No presubmit jobs available for pingcap/tidb@release-8.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test build |
@windtalker: No presubmit jobs available for pingcap/tidb@release-8.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #57373 +/- ##
================================================
Coverage ? 71.2167%
================================================
Files ? 1467
Lines ? 423351
Branches ? 0
================================================
Hits ? 301497
Misses ? 101351
Partials ? 20503
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #57274
What problem does this PR solve?
Issue Number: close #55885
Problem Summary:
The root cause is in Limit executor, it has an inline projection, but it use
chunk.SwapColumn
directly to do the projection, which will cause error if theLimit
's output contains multiple column that point to same shallow column in input ChunkWhat changed and how does it work?
This pr
chunk.SwapColumn
a private method, so it will not be used mistakenlyColumnEvaluator
toColumnSwapHelper
and move it fromexpression
package tochunk
packageColumnSwapHelper
to do the inline projection inLimit
executor.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.