Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: make chunk.SwapColumn private (#57274) #57373

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57274

What problem does this PR solve?

Issue Number: close #55885

Problem Summary:
The root cause is in Limit executor, it has an inline projection, but it use chunk.SwapColumn directly to do the projection, which will cause error if the Limit's output contains multiple column that point to same shallow column in input Chunk

What changed and how does it work?

This pr

  1. make chunk.SwapColumn a private method, so it will not be used mistakenly
  2. Rename ColumnEvaluator to ColumnSwapHelper and move it from expression package to chunk package
  3. use ColumnSwapHelper to do the inline projection in Limit executor.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Nov 14, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2024
13 tasks
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 14, 2024
@windtalker windtalker force-pushed the cherry-pick-57274-to-release-8.1 branch from 2f45eef to 3f58b0b Compare November 15, 2024 09:12
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 15, 2024
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 15, 2024
@windtalker
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented Nov 17, 2024

@windtalker: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@windtalker
Copy link
Contributor

/test build

Copy link

tiprow bot commented Nov 17, 2024

@windtalker: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 91.07143% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@af934cf). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #57373   +/-   ##
================================================
  Coverage               ?   71.2167%           
================================================
  Files                  ?       1467           
  Lines                  ?     423351           
  Branches               ?          0           
================================================
  Hits                   ?     301497           
  Misses                 ?     101351           
  Partials               ?      20503           
Flag Coverage Δ
unit 71.2167% <91.0714%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.3256% <0.0000%> (?)

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

ti-chi-bot bot commented Nov 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 17, 2024
Copy link

ti-chi-bot bot commented Nov 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-15 11:23:16.388380542 +0000 UTC m=+614558.579249531: ☑️ agreed by AilinKid.
  • 2024-11-17 11:23:23.200184274 +0000 UTC m=+787365.391053270: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit 9349e33 into pingcap:release-8.1 Nov 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants