-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dxf: fix the task num count incorrectly (#57127) #57386
dxf: fix the task num count incorrectly (#57127) #57386
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57386 +/- ##
================================================
Coverage ? 56.8451%
================================================
Files ? 1770
Lines ? 625668
Branches ? 0
================================================
Hits ? 355662
Misses ? 245975
Partials ? 24031
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fzzf678, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #57127
What problem does this PR solve?
Issue Number: close #57172
Problem Summary:
What changed and how does it work?
The task count metric is updating in scheduler loop, but the task maybe cleaned up in
doCleanupTask()
, the scheduler will not handle the finished/failed... state, so the task count metric will not be reduced.Check List
Tests
Use sysbench prepare 100 tables with 10000 rows. Watch the pannel:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.