-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning/importinto: set correct step to create single point allocator (#56602) #57925
lightning/importinto: set correct step to create single point allocator (#56602) #57925
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/retest |
/test pull-lightning-integration-test |
@D3Hunter: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@D3Hunter: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ti-chi-bot[bot]: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-br-integration-test |
@D3Hunter: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@D3Hunter: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ti-chi-bot[bot]: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/run-integration-br-test |
2 similar comments
/run-integration-br-test |
/run-integration-br-test |
/test pull-br-integration-test |
@D3Hunter: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #57925 +/- ##
================================================
Coverage ? 72.3159%
================================================
Files ? 1415
Lines ? 414394
Branches ? 0
================================================
Hits ? 299673
Misses ? 94767
Partials ? 19954
Flags with carried forward coverage won't be shown. Click here to find out more.
|
all lightning ci pass, as no br code changed, won't wait those flaky br cases https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Frelease-7.5%2Fpull_br_integration_test/detail/pull_br_integration_test/41/pipeline/420 |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
This reverts commit a507b54.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm though no real br change in 7.5
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, Benjamin2037, BornChanger, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
This is an automated cherry-pick of #56602
What problem does this PR solve?
Issue Number: close #56476
Problem Summary:
What changed and how does it work?
we must set
autoid.CustomAutoIncCacheOption(1)
to create a new single point allocator, else it's always normal oneCheck List
Tests
import into is test manually with same case as lightning. when I try add to real-tikv-test, it report
autoid service leader not found
, something might not be mocked.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.