-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning, ddl: set TS to engineMeta after ResetEngineSkipAllocTS (#57998) #58032
lightning, ddl: set TS to engineMeta after ResetEngineSkipAllocTS (#57998) #58032
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: lance6716 <lance6716@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #58032 +/- ##
================================================
Coverage ? 71.1923%
================================================
Files ? 1467
Lines ? 423457
Branches ? 0
================================================
Hits ? 301469
Misses ? 101484
Partials ? 20504
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/hold need to fix CI |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #57998
What problem does this PR solve?
Issue Number: close #57980
Problem Summary:
What changed and how does it work?
Previously, after reset engine we set the TS to
EngineConfig
. ButengineMeta
is the place that really take effect. The conversion fromEngineConfig
toengineMeta
happens when 1) engine is opened, or 2) external engine is closed normally. In disk-quota triggered import, above conversion does not happenCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.