executor: Fix query hang on hash aggregate operator #6982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
winoros
reviewed
Jul 4, 2018
|
@winoros Test is on the tidb-private-test, no need to add |
|
@zz-jason It can also improve the test coverage. Unit test doesn't cover |
|
LGTM |
|
I will merge this to save the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
there can be a situation that the final worker of hash aggregate can be blocked in receiving from the
finalResultHolderChand the main thread blocked in receiving from thefinalOutputCh, which is closed when final worker exits.actually the final work should be able to detect the query is finished when receiving from the
finalResultHolderCh, so I use aselectto do the receiving work.What are the type of the changes (mandatory)?
How has this PR been tested (mandatory)?