Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: kill one's own connection doesn't require SUPER privilege (#6954) #7003

Merged
merged 2 commits into from
Jul 6, 2018

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Jul 6, 2018

What have you changed? (mandatory)

cherry pick from #6954

`kill tidb connID`, if the user is the owner of that connection, there
is no need to check the SUPER privilege.
SessionManager interface is slightly modified.

What are the type of the changes (mandatory)?

  • Bug fix (non-breaking change which fixes an issue)

…#6954)

`kill tidb connID`, if the user is the owner of that connection, there
is no need to check the SUPER privilege.
SessionManager interface is slightly modified.
@shenli
Copy link
Member

shenli commented Jul 6, 2018

  1. The title has nothing to do with the content.
  2. Please add proper labels to this PR.

@tiancaiamao tiancaiamao changed the title privilege/privileges: don't reuse chunk in loadTable function (#6976) *: kill one's own connection doesn't require SUPER privilege (#6954) Jul 6, 2018
@tiancaiamao
Copy link
Contributor Author

PTAL @shenli @zimulala @jackysp

@tiancaiamao
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason zz-jason merged commit 3835845 into pingcap:release-2.0 Jul 6, 2018
@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 6, 2018
@tiancaiamao tiancaiamao deleted the cherry-pick branch July 6, 2018 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants