Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tablecodec: optimize DecodeRowKey #7149

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Conversation

coocood
Copy link
Member

@coocood coocood commented Jul 25, 2018

What have you changed? (mandatory)

reimplement DecodeRowKey for better performance.

What is the type of the changes? (mandatory)

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Unit test

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

NO

Does this PR affect tidb-ansible update? (mandatory)

NO

Does this PR need to be added to the release notes? (mandatory)

NO

Benchmark result if necessary (optional)

from 13.4 ns/op to 3.83 ns/op

@coocood
Copy link
Member Author

coocood commented Jul 25, 2018

@ngaut @zz-jason PTAL

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 25, 2018
@coocood
Copy link
Member Author

coocood commented Jul 25, 2018

/run-all-tests

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 25, 2018
@winoros winoros merged commit 4ae23a9 into pingcap:master Jul 25, 2018
@coocood coocood deleted the decode-row-key branch July 25, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants