Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: disable read committed isolation level #7282

Merged
merged 2 commits into from
Aug 6, 2018

Conversation

coocood
Copy link
Member

@coocood coocood commented Aug 6, 2018

Cherry-pick #7280

read committed isolation may cause inconsistent read.

What have you changed? (mandatory)

disable read committed isolation level

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

Run concurrent DML statements with admin check table.

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

YES

Does this PR affect tidb-ansible update? (mandatory)

NO

Does this PR need to be added to the release notes? (mandatory)

YES

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@coocood coocood added type/2.0 cherry-pick priority/release-blocker This issue blocks a release. Please solve it ASAP. labels Aug 6, 2018
@coocood
Copy link
Member Author

coocood commented Aug 6, 2018

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

@coocood
Copy link
Member Author

coocood commented Aug 6, 2018

@shenli @winkyao PTAL

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli shenli merged commit 702b551 into pingcap:release-2.0 Aug 6, 2018
@coocood coocood deleted the disable-read-committed-2.0 branch August 6, 2018 09:00
@zhexuany zhexuany added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants