Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: skip inner rows when the join keys contains NULL (#7255) #7301

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Aug 7, 2018

What have you changed? (mandatory)

cherry-pick #7255 to release-2.0

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

  • existing test
  • newly add UT

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Does this PR need to be added to the release notes? (mandatory)

An example:

release note:
Fix the wrong behavior of `Merge Join` and `Index Join` in a special scenario.

@zz-jason zz-jason added type/bugfix This PR fixes a bug. type/2.0 cherry-pick sig/execution SIG execution release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 7, 2018
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member

coocood commented Aug 8, 2018

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

@zz-jason zz-jason merged commit 478d990 into pingcap:release-2.0 Aug 8, 2018
@zz-jason zz-jason deleted the cherry-pick/7255 branch August 8, 2018 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants