-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add HIGH_PRIORITY for the bootstrap SQLs. #7616
Conversation
/run-all-tests |
@@ -36,11 +36,11 @@ import ( | |||
"math/rand" | |||
"net" | |||
"net/http" | |||
// For pprof |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is made by gofmt
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to @hicqu , this PR could not solve the problem described in the description.
SQL with HIGH_PRIORITY would not be promised to be executed before the NORMAL_PRIORITY now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got it, HIGH_PRIORITY task can be handled in a short time if there are few HIGH_PRIORITY tasks in the task queue, rather than waiting until out of time when be set as NORMAL_PRIORITY.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Some important SQLs could failed when TiDB is starting. This PR try to improve this.
What is changed and how it works?
Add HIGH_PRIORITY for the bootstrap SQLs.
Check List
Tests
debug
, add os.Exit(0) aftertidb/server/server.go
Line 241 in 1a97152
Code changes
Side effects
Related changes
PTAL @winkyao @breeswish