Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: fix single line comment end with newline (#7612) #7635

Merged
merged 1 commit into from
Sep 7, 2018
Merged

parser: fix single line comment end with newline (#7612) #7635

merged 1 commit into from
Sep 7, 2018

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Sep 6, 2018

What problem does this PR solve?

cherry-pick for #7612

Check List

Tests

  • Unit test

Code changes

  • impl

Side effects

  • no

This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Sep 6, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@shenli
Copy link
Member

shenli commented Sep 6, 2018

LGTM

@shenli shenli added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 6, 2018
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 6, 2018
@zz-jason zz-jason merged commit c4417f4 into pingcap:release-2.0 Sep 7, 2018
@lysu lysu deleted the cherry-pick-comment branch September 7, 2018 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mysql-protocol status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants