planner, executor: eliminate extra columns introduced by OrderBy upon Union #8290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
/run-all-tests |
XuHuaiyu
changed the title
zz-jason
added
contribution
|
/run-all-tests |
winoros
reviewed
Nov 13, 2018
AndrewDi
force-pushed
the
fix_union_orderby
branch
from
7065750
to
274adae
Compare
… introduced by OrderBy upon Union
AndrewDi
force-pushed
the
fix_union_orderby
branch
from
274adae
to
137230d
Compare
winoros
reviewed
Nov 13, 2018
|
/run-all-tests |
|
@AndrewDi It seems that we should cherry-pick this to release-2.1 and release-2.0? |
AndrewDi
added a commit
to AndrewDi/tidb
that referenced
this pull request
Nov 14, 2018
AndrewDi
added a commit
to AndrewDi/tidb
that referenced
this pull request
Nov 14, 2018
zz-jason
pushed a commit
that referenced
this pull request
Nov 14, 2018
zz-jason
pushed a commit
that referenced
this pull request
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix issue #8189 and issue #8199
What is changed and how it works?
When a
SELECTstatement containsUNIONandORDER BYcause contains select statement,TiDB will generate extra columns, so I addLogicalProjectionwhen building union LogicalPlan to eliminate generated extra columns.Check List
Tests
Code changes
Side effects
Related changes