server: reset bound arguments when it is executed by execute command #8645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests tidb-test=pr/689 |
2 similar comments
|
/run-all-tests tidb-test=pr/689 |
|
/run-all-tests tidb-test=pr/689 |
|
/run-common-test tidb-test=pr/689 |
|
/run-integration-common-test tidb-test=pr/689 |
zimulala
reviewed
Dec 11, 2018
|
Hard to do, @zimulala . go-sql-driver doesn't use |
lysu
approved these changes
Dec 11, 2018
lysu
added
status/LGT2
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Dec 11, 2018
jackysp
added a commit
that referenced
this pull request
Dec 12, 2018
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Dec 13, 2018
zimulala
pushed a commit
that referenced
this pull request
Dec 13, 2018
iamzhoug37
pushed a commit
to iamzhoug37/tidb
that referenced
this pull request
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
comStmtSendLongDatawill always append values no matter the arguments are used or not. It will causethe second statement will insert "ab" not "b" if the client use
comStmtSendLongData.What is changed and how it works?
Reset the bound arguments when executing.
Check List
Tests
JDBC test case. https://github.com/pingcap/tidb-test/pull/689
Code changes
Related changes
PTAL @lysu
This change is