Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: modify different character sets varchar type column maximum length limit #9050

Merged
merged 5 commits into from
Jan 16, 2019

Conversation

ciscoxll
Copy link
Contributor

Cherry pick #8818


This change is Reviewable

@ciscoxll
Copy link
Contributor Author

@winkyao @tiancaiamao @crazycs520 PTAL

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ddl/ddl_api.go Outdated Show resolved Hide resolved
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 14, 2019
@crazycs520
Copy link
Contributor

/run-all-tests

@ciscoxll
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

1 similar comment
@ciscoxll
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@ngaut ngaut merged commit cbae3d6 into pingcap:release-2.1 Jan 16, 2019
@ciscoxll ciscoxll deleted the cp-varchar-limit branch January 16, 2019 11:52
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants