Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix a bug when adding an index to a generated column with an expression error (#9216) #9289

Merged
merged 2 commits into from
Feb 13, 2019

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Feb 12, 2019

What problem does this PR solve?

cherry-pick #9216(fix #9214).

@zimulala
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@zimulala
Copy link
Contributor Author

PTAL @jackysp @ciscoxll @xiekeyi98

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 13, 2019
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 13, 2019
@zz-jason zz-jason merged commit 230393a into pingcap:release-2.1 Feb 13, 2019
@zimulala zimulala deleted the generated-col branch February 13, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants