executor: deep copy json into partial result #9833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed case in check_dev is a little strange. |
eurekaka
reviewed
Mar 21, 2019
eurekaka
reviewed
Mar 21, 2019
|
/run-common-test && just test ci.. |
Codecov Report
@@ Coverage Diff @@
## master #9833 +/- ##
================================================
+ Coverage 77.2356% 77.2738% +0.0382%
================================================
Files 405 405
Lines 81667 81668 +1
================================================
+ Hits 63076 63108 +32
+ Misses 13919 13877 -42
- Partials 4672 4683 +11 |
… into bugfix/firstrow-json
|
/run-all-tests |
|
/run-integration-common-test |
|
/run-integration-common-test |
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Mar 28, 2019
zz-jason
added a commit
that referenced
this pull request
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
expression.EvalJSON() only returns a shallow copy of the JSON content in Chunk. We need to deep copy it to avoid dirty memory.
What is changed and how it works?
deep copy JSON into partial result
Check List
Tests
Related changes