Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: refine the parsing logic of INTERVAL to correct DATE_ADD/DATE_SUB (#9874) #9963

Merged
merged 1 commit into from
Mar 31, 2019

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Mar 31, 2019

What problem does this PR solve?

Cherry-pick from #9874
refine the parsing logic of INTERVAL to correct DATE_ADD/DATE_SUB.

What is changed and how it works?

modify ExtractTimeValue function to compatible with Mysql

Check List

Tests

  • Unit test
  • Integration test

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason changed the title cherry pick types: refine the parsing logic of INTERVAL to correct DATE_ADD/DATE_SUB (#9874) types: refine the parsing logic of INTERVAL to correct DATE_ADD/DATE_SUB (#9874) Mar 31, 2019
@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. contribution This PR is from a community contributor. type/bugfix This PR fixes a bug. component/expression type/2.1 cherry-pick labels Mar 31, 2019
@zz-jason
Copy link
Member

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason requested review from lysu and xiekeyi98 March 31, 2019 11:25
Copy link
Contributor

@xiekeyi98 xiekeyi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for your contribution.

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2019
@zz-jason zz-jason merged commit 6f82fd7 into pingcap:release-2.1 Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants