Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build tiflash within exchange_perftest tests. #4276

Closed
jiaqizho opened this issue Mar 15, 2022 · 5 comments · Fixed by #5137
Closed

Can't build tiflash within exchange_perftest tests. #4276

jiaqizho opened this issue Mar 15, 2022 · 5 comments · Fixed by #5137
Assignees
Labels
component/compute good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/minor type/bug The issue is confirmed as a bug.

Comments

@jiaqizho
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. cmake .. -DCMAKE_BUILD_TYPE=Debug -DENABLE_TESTS=ON
  2. make -j

Then will got error

/xxxxxxx/dbms/src/Flash/Mpp/MPPTunnel.cpp:67:17: error: no member named 'tryFlushOne' in 'DB::tests::(anonymous namespace)::MockWriter'
        writer->tryFlushOne();
        ~~~~~~  ^
/xxxxxxx/dbms/src/Flash/Mpp/MPPTunnel.cpp:51:13: note: in instantiation of member function 'DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>::finishSendQueue' requested here
            finishSendQueue();
            ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/memory:1933:3: note: in instantiation of member function 'DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>::~MPPTunnelBase' requested here
  __compressed_pair_elem(piecewise_construct_t, tuple<_Args...> __args,
  ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/memory:4038:26: note: in instantiation of function template specialization 'std::__1::__shared_ptr_emplace<DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>, std::__1::allocator<DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>>>::__shared_ptr_emplace<mpp::TaskMeta &, mpp::TaskMeta &, std::__1::chrono::duration<long long>, const int &, bool>' requested here
    ::new(__hold2.get()) _CntrlBlk(__a2, _VSTD::forward<_Args>(__args)...);
                         ^
/xxxxxxx/dbms/src/Flash/tests/exchange_perftest.cpp:505:32: note: in instantiation of function template specialization 'std::__1::make_shared<DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>, mpp::TaskMeta &, mpp::TaskMeta &, std::__1::chrono::duration<long long>, const int &, bool>' requested here
            auto tunnel = std::make_shared<MockTunnel>(
                               ^
In file included from /xxxxxxx/dbms/src/Flash/tests/exchange_perftest.cpp:15:
/xxxxxxx/dbms/src/Flash/Mpp/MPPTunnel.cpp:151:26: error: no member named 'write' in 'DB::tests::(anonymous namespace)::MockWriter'
            if (!writer->write(*res))
                 ~~~~~~  ^
/xxxxxxx/dbms/src/Flash/Mpp/MPPTunnel.cpp:235:21: note: in instantiation of member function 'DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>::sendJob' requested here
                    sendJob();
                    ^
/xxxxxxx/dbms/src/Flash/tests/exchange_perftest.cpp:511:21: note: in instantiation of member function 'DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>::connect' requested here
            tunnel->connect(writer.get());
                    ^
In file included from /xxxxxxx/dbms/src/Flash/tests/exchange_perftest.cpp:15:
/xxxxxxx/dbms/src/Flash/Mpp/MPPTunnel.cpp:179:17: error: no member named 'writeDone' in 'DB::tests::(anonymous namespace)::MockWriter'
        writer->writeDone(grpc::Status::OK);
        ~~~~~~  ^
/xxxxxxx/dbms/src/Flash/Mpp/MPPTunnel.cpp:122:25: error: no member named 'tryFlushOne' in 'DB::tests::(anonymous namespace)::MockWriter'
                writer->tryFlushOne();
                ~~~~~~  ^
/xxxxxxx/dbms/src/Flash/Mpp/MPPTunnelSet.cpp:94:28: note: in instantiation of member function 'DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>::write' requested here
    tunnels[partition_id]->write(packet);
                           ^
/xxxxxxx/dbms/src/Flash/Coprocessor/StreamingDAGResponseWriter.cpp:282:25: note: in instantiation of member function 'DB::MPPTunnelSetBase<DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>>::write' requested here
                writer->write(packet[part_id], part_id);
                        ^
/xxxxxxx/dbms/src/Flash/Coprocessor/StreamingDAGResponseWriter.cpp:296:9: note: in instantiation of function template specialization 'DB::StreamingDAGResponseWriter<std::__1::shared_ptr<DB::MPPTunnelSetBase<DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>>>>::partitionAndEncodeThenWriteBlocks<false>' requested here
        partitionAndEncodeThenWriteBlocks<send_exec_summary_at_last>(blocks, response);
        ^
/xxxxxxx/dbms/src/Flash/Coprocessor/StreamingDAGResponseWriter.cpp:82:9: note: in instantiation of function template specialization 'DB::StreamingDAGResponseWriter<std::__1::shared_ptr<DB::MPPTunnelSetBase<DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>>>>::batchWrite<false>' requested here
        batchWrite<false>();
        ^
/xxxxxxx/dbms/src/Flash/Coprocessor/StreamingDAGResponseWriter.h:26:5: note: in instantiation of member function 'DB::StreamingDAGResponseWriter<std::__1::shared_ptr<DB::MPPTunnelSetBase<DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>>>>::write' requested here
    StreamingDAGResponseWriter(
    ^
/xxxxxxx/dbms/src/Flash/tests/exchange_perftest.cpp:537:21: note: in instantiation of member function 'DB::StreamingDAGResponseWriter<std::__1::shared_ptr<DB::MPPTunnelSetBase<DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>>>>::StreamingDAGResponseWriter' requested here
                new StreamingDAGResponseWriter<MockTunnelSetPtr>(
                    ^
In file included from /xxxxxxx/dbms/src/Flash/tests/exchange_perftest.cpp:13:
/xxxxxxx/dbms/src/Flash/Coprocessor/StreamingDAGResponseWriter.cpp:105:29: error: no matching member function for call to 'write'
                    writer->write(packet);
                    ~~~~~~~~^~~~~

I think this build issue come from #4120

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)

@jiaqizho jiaqizho added the type/bug The issue is confirmed as a bug. label Mar 15, 2022
@jiaqizho jiaqizho assigned bestwoody and fuzhe1989 and unassigned bestwoody Mar 15, 2022
@bestwoody
Copy link
Contributor

will solve it as fast as possible

@fuzhe1989
Copy link
Contributor

fuzhe1989 commented Mar 15, 2022

@bestwoody please take easy, this break won't block anything. Leave it to me and I'll fix it next week.

@JaySon-Huang
Copy link
Contributor

downgrade the severity to minor since it is only a performance test and won't block anything.

@JaySon-Huang
Copy link
Contributor

Another report from #4771 (comment).

@JaySon-Huang JaySon-Huang added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed may-affects-4.0 may-affects-5.0 may-affects-5.1 may-affects-5.2 may-affects-5.3 may-affects-5.4 labels Apr 27, 2022
@fuzhe1989
Copy link
Contributor

I'll fix it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/compute good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
6 participants