Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine the "stable" PageStorage #784

Closed
JaySon-Huang opened this issue Jun 16, 2020 · 1 comment
Closed

Refine the "stable" PageStorage #784

JaySon-Huang opened this issue Jun 16, 2020 · 1 comment
Assignees
@JaySon-Huang
Labels
priority/P2 The issue has P2 priority. type/enhancement The issue or PR belongs to an enhancement.

Comments

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jun 16, 2020 •
edited
Loading

We introduced a new PageStorage which support multi-threads write in #464. It was a big change for PageStorage code.
I have supported backward compatibility for reading single page file of the older format, but I was not sure it can completely handle all old format data (including the checkpoint, legacy, formal page file data). To keep the stability of TiFlash at that time, I only use the new PageStorage for DeltaTree, while keeping the old code as "stable::PageStorage" for storing raft data.

Having two version codebase for PageStorage may make some trouble if we support encryption or other new features for PageStorage. We'd better add some test cases to ensure we can unify them and upgrade can performance smoothly.
@JaySon-Huang JaySon-Huang self-assigned this Jun 16, 2020
@JaySon-Huang JaySon-Huang mentioned this issue Jun 19, 2020
Merged
@zanmato1984 zanmato1984 added the type/enhancement The issue or PR belongs to an enhancement. label Jul 1, 2020
@ti-srebot ti-srebot mentioned this issue Jul 27, 2020
Merged
@JaySon-Huang JaySon-Huang added the priority/P2 The issue has P2 priority. label Jul 29, 2020
@ti-srebot ti-srebot mentioned this issue Aug 4, 2020
Merged
@JaySon-Huang
Copy link
Contributor Author

Done in this PR: #1199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaySon-Huang JaySon-Huang

Labels
priority/P2 The issue has P2 priority. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zanmato1984 @JaySon-Huang