Support multi-disks for RegionPersister #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaySon-Huang
changed the title
JaySon-Huang
force-pushed
the
refine_region_persister
branch
3 times, most recently
from
64a52fb
to
2744864
Compare
JaySon-Huang
changed the title
Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
force-pushed
the
refine_region_persister
branch
from
1970231
to
20fe0d6
Compare
|
/run-all-tests |
flowbehappy
reviewed
Nov 6, 2020
flowbehappy
reviewed
Nov 9, 2020
dbms/src/Storages/PathPool.cpp
Outdated
Comment on lines
43
to
45
| auto p = Poco::Path{s + "/kvstore"}.toString(); | ||
| if (p.back() == '/') | ||
| p.erase(p.begin() + p.size() - 1); |
There was a problem hiding this comment.
Please put those lines into a function and call it. So do other places.
|
/rebuild |
|
/run-all-tests |
|
/run-all-tests |
flowbehappy
reviewed
Nov 11, 2020
| @@ -245,6 +269,12 @@ TiFlashRaftConfig::TiFlashRaftConfig(const std::string & path, Poco::Util::Layer | |||
| ErrorCodes::INVALID_CONFIG_PARAMETER); | |||
| disable_bg_flush = true; | |||
| } | |||
|
|
|||
| // just for test | |||
| if (config.has("raft.enable_compatibility_mode")) | |||
There was a problem hiding this comment.
Suggested change
| if (config.has("raft.enable_compatibility_mode")) | |
| if (config.has("raft.enable_compatible_mode")) |
There was a problem hiding this comment.
OK, will solve it in the next PR.
flowbehappy
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaySon-Huang tshent@qq.com
What problem does this PR solve?
Issue Number: a part of #1128
Problem Summary:
What is changed and how it works?
PSDiskDelegatorRaftfor managing the disks of Raft datalatest_data_pathDB::stable::PageStorage)DB::PageStorageDB::PageStorageRelated changes
Check List
Tests
Side effects
Release note