Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix date format identifies '\n' as invalid separator #4046

Merged
merged 9 commits into from
Feb 16, 2022
Merged

fix date format identifies '\n' as invalid separator #4046

merged 9 commits into from
Feb 16, 2022

Conversation

mengxin9014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4036

Problem Summary:

fix date formate identifies '\n' is invalid separator

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

fix date format identifies '\n' as invalid separator

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 16, 2022
@mengxin9014 mengxin9014 self-assigned this Feb 16, 2022
@mengxin9014 mengxin9014 added needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Feb 16, 2022
@mengxin9014
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Feb 16, 2022

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyTime.cpp                                 980               201    79.49%         105                26    75.24%        2019               492    75.63%         872               246    71.79%
Functions/tests/gtest_tidb_conversion.cpp        3249               794    75.56%          30                 0   100.00%        1288                 0   100.00%        1002               512    48.90%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            4229               995    76.47%         135                26    80.74%        3307               492    85.12%        1874               758    59.55%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16405      9530             41.91%    180879  96551        46.62%

full coverage report (for internal network access only)

@mengxin9014
Copy link
Contributor Author

/run-all-tests

Signed-off-by: mengxin <tregoldmeng@gmail.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 16, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Feb 16, 2022

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyTime.cpp                                 982               201    79.53%         105                26    75.24%        2019               492    75.63%         874               247    71.74%
Functions/tests/gtest_tidb_conversion.cpp        3249               794    75.56%          30                 0   100.00%        1288                 0   100.00%        1002               512    48.90%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            4231               995    76.48%         135                26    80.74%        3307               492    85.12%        1876               759    59.54%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16405      9531             41.90%    180879  96570        46.61%

full coverage report (for internal network access only)

@mengxin9014
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Feb 16, 2022

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyTime.cpp                                 980               201    79.49%         105                26    75.24%        2019               492    75.63%         872               246    71.79%
Functions/tests/gtest_tidb_conversion.cpp        3249               794    75.56%          30                 0   100.00%        1288                 0   100.00%        1002               512    48.90%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            4229               995    76.47%         135                26    80.74%        3307               492    85.12%        1874               758    59.55%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16405      9531             41.90%    180879  96567        46.61%

full coverage report (for internal network access only)

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 16, 2022
@mengxin9014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@mengxin9014: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 16, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Feb 16, 2022

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyTime.cpp                                 980               200    79.59%         105                26    75.24%        2019               489    75.78%         872               245    71.90%
Functions/tests/gtest_tidb_conversion.cpp        3249               794    75.56%          30                 0   100.00%        1288                 0   100.00%        1002               512    48.90%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            4229               994    76.50%         135                26    80.74%        3307               489    85.21%        1874               757    59.61%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16409      9512             42.03%    181106  96309        46.82%

full coverage report (for internal network access only)

@mengxin9014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@mengxin9014: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Feb 16, 2022

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyTime.cpp                                 980               200    79.59%         105                26    75.24%        2019               489    75.78%         872               245    71.90%
Functions/tests/gtest_tidb_conversion.cpp        3249               794    75.56%          30                 0   100.00%        1288                 0   100.00%        1002               512    48.90%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            4229               994    76.50%         135                26    80.74%        3307               489    85.21%        1874               757    59.61%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16410      9514             42.02%    181110  96317        46.82%

full coverage report (for internal network access only)

@mengxin9014 mengxin9014 merged commit 745bcce into pingcap:master Feb 16, 2022
@mengxin9014 mengxin9014 deleted the mx/fixDateFormat branch February 16, 2022 11:08
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 16, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4055.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 16, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4056.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 16, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4057.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4058.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 16, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 16, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4059.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4060.

mengxin9014 added a commit that referenced this pull request Feb 17, 2022
* fix date format identifies '\n' as invalid separator

* for clang tidy

* for clang tidy

Signed-off-by: mengxin <tregoldmeng@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

date_format of string to time with "\n" has different behavior with MySQL
4 participants