Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpp task handle pingcap exception (#4102) #4114

Merged
merged 4 commits into from
Jun 20, 2022
Merged

mpp task handle pingcap exception (#4102) #4114

merged 4 commits into from
Jun 20, 2022

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 23, 2022 •
edited by JaySon-Huang
Loading

This is an automated cherry-pick of #4102

What problem does this PR solve?

Issue Number: close #4101

Problem Summary:
mpp task handle pingcap exception

Release note

Fix the bug that some exceptions are not handled properly

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mengxin9014
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-5.3 labels Feb 23, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 23, 2022
Merged
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 14, 2022
@JaySon-Huang JaySon-Huang added this to the v5.3.2 milestone Jun 15, 2022
zanmato1984
zanmato1984 approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2022
@mengxin9014
Copy link
Contributor

/run-all-tests

@mengxin9014
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@mengxin9014: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

@mengxin9014: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 20, 2022
@mengxin9014
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@mengxin9014: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 3088816

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 20, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jun 20, 2022

lines: 36.1% (43251 out of 119733)
branches: 5.4% (66554 out of 1223900)

@ti-chi-bot ti-chi-bot merged commit a859794 into pingcap:release-5.3 Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengxin9014 mengxin9014 mengxin9014 approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

Assignees

@mengxin9014 mengxin9014

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3
Projects
None yet
Milestone
v5.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @mengxin9014 @sre-bot @zanmato1984 @JaySon-Huang @VelocityLight