Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CRC64 as checksum algo for LogFile #4261

Merged
merged 10 commits into from
Mar 15, 2022
Merged

Use CRC64 as checksum algo for LogFile #4261

merged 10 commits into from
Mar 15, 2022

Conversation

JaySon-Huang
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary:

What is changed and how it works?

  • Use CRC64 (aligned with BlobFile) as the checksum algo for LogFile
  • Refine the unit test cases

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

JaySon-Huang and others added 3 commits March 14, 2022 21:29
@JaySon-Huang
Use CRC64 as checksum for LogFile. Refine some testing codes
37ff827 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Debug log
60820e5
@JaySon-Huang
Revert "Debug log"
df626ec 
This reverts commit 60820e5.
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jiaqizho
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 14, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 14, 2022
jiaqizho
jiaqizho approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@jiaqizho jiaqizho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with little comments

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2022
@JaySon-Huang
Copy link
Contributor Author

@lidezhu PTAL

@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

lidezhu
lidezhu approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 15, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
LogFile/LogReader.cpp             145                12    91.72%           8                 0   100.00%         285                20    92.98%         122                18    85.25%
LogFile/LogWriter.h                 1                 0   100.00%           1                 0   100.00%           3                 0   100.00%           0                 0         -
tests/gtest_wal_log.cpp          2523               370    85.33%          49                 0   100.00%         530                 1    99.81%         772               351    54.53%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            2669               382    85.69%          58                 0   100.00%         818                21    97.43%         894               369    58.72%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16907      9490             43.87%    190386  96257        49.44%

full coverage report (for internal network access only)

@JaySon-Huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fb3af31

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 15, 2022

Coverage for changed files

Filename                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Mpp/MPPTask.cpp                                            395               395     0.00%          20                20     0.00%         328               328     0.00%         176               176     0.00%
Flash/Mpp/MPPTask.h                                                3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
Flash/Mpp/MPPTaskManager.cpp                                      97                96     1.03%          11                10     9.09%         173               172     0.58%          70                70     0.00%
Flash/Mpp/MPPTaskManager.h                                         1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Flash/Mpp/MPPTunnel.cpp                                          175               175     0.00%          16                16     0.00%         233               233     0.00%          90                90     0.00%
Flash/Mpp/MinTSOScheduler.cpp                                    228               213     6.58%           7                 6    14.29%         145               135     6.90%         132               127     3.79%
Flash/Mpp/MinTSOScheduler.h                                        4                 1    75.00%           2                 0   100.00%           4                 0   100.00%           4                 3    25.00%
Interpreters/Settings.h                                            1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Storages/DeltaMerge/Delta/ColumnFileFlushTask.cpp                 32                 2    93.75%           3                 0   100.00%          59                 5    91.53%          20                 2    90.00%
Storages/DeltaMerge/tests/gtest_dm_delta_merge_store.cpp        6008              1604    73.30%          37                 1    97.30%        2712                93    96.57%        2002               886    55.74%
Storages/Page/V3/LogFile/LogReader.cpp                           145                12    91.72%           8                 0   100.00%         285                20    92.98%         122                18    85.25%
Storages/Page/V3/LogFile/LogWriter.h                               1                 0   100.00%           1                 0   100.00%           3                 0   100.00%           0                 0         -
Storages/Page/V3/tests/gtest_wal_log.cpp                        2523               370    85.33%          49                 0   100.00%         530                 1    99.81%         772               351    54.53%
Storages/StorageDeltaMerge.cpp                                   669               360    46.19%          56                29    48.21%        1292               762    41.02%         378               259    31.48%
Storages/Transaction/TMTContext.cpp                               53                37    30.19%          34                19    44.12%         149               102    31.54%          12                11     8.33%
Storages/Transaction/TMTContext.h                                  4                 3    25.00%           4                 3    25.00%           4                 3    25.00%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                          10339              3271    68.36%         253               107    57.71%        5922              1857    68.64%        3778              1993    47.25%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16923      9504             43.84%    190669  96495        49.39%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 15, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16923      9504             43.84%    190675  96452        49.42%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit db28b92 into pingcap:master Mar 15, 2022
@JaySon-Huang JaySon-Huang deleted the ps_log_crc64 branch March 15, 2022 13:25
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Mar 17, 2022
@JaySon-Huang
Use CRC64 as checksum algo for LogFile (pingcap#4261)
c8d66b8 
ref pingcap#3594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidezhu lidezhu lidezhu approved these changes

@jiaqizho jiaqizho jiaqizho approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JaySon-Huang @ti-chi-bot @sre-bot @jiaqizho @lidezhu