Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Rename tics to tiflash. #4296

Merged
merged 5 commits into from
Mar 16, 2022
Merged

README.md: Rename tics to tiflash. #4296

merged 5 commits into from
Mar 16, 2022

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Mar 16, 2022

What problem does this PR solve?

Issue Number: ref #4019

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SchrodingerZhu
  • ngaut

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 16, 2022
@JinheLin JinheLin requested review from zanmato1984 and SchrodingerZhu and removed request for zanmato1984 March 16, 2022 03:47
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2022
@JinheLin
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 72a3138

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 16, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16922      9502             43.85%    190607  96473        49.39%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 16, 2022

Coverage for changed files

Filename                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/TiFlashMetrics.h                             18                 0   100.00%          11                 0   100.00%          47                 1    97.87%           8                 0   100.00%
Flash/Coprocessor/DAGUtils.cpp                     290               233    19.66%          36                24    33.33%         505               404    20.00%         324               230    29.01%
Flash/EstablishCall.h                                2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
Flash/Mpp/MPPTunnel.cpp                            185               185     0.00%          16                16     0.00%         241               241     0.00%          94                94     0.00%
Flash/Mpp/MPPTunnel.h                                9                 9     0.00%           9                 9     0.00%          18                18     0.00%           0                 0         -
Functions/FunctionsDateTime.cpp                     27                19    29.63%           4                 2    50.00%          99                25    74.75%          16                13    18.75%
Functions/FunctionsDateTime.h                     1073               638    40.54%         322               209    35.09%        2018              1226    39.25%         534               340    36.33%
Functions/tests/gtest_dayofweekyear.cpp            258                74    71.32%           2                 0   100.00%         135                 0   100.00%          80                42    47.50%
Storages/Page/V3/WAL/WALReader.cpp                  72                10    86.11%           9                 0   100.00%         176                15    91.48%          54                14    74.07%
Storages/Page/V3/WALStore.cpp                       74                39    47.30%           8                 1    87.50%         134                42    68.66%          36                19    47.22%
Storages/Page/V3/WALStore.h                          1                 0   100.00%           1                 0   100.00%           3                 0   100.00%           0                 0         -
Storages/Page/V3/tests/gtest_wal_store.cpp        1948               260    86.65%          12                 0   100.00%         465                13    97.20%         646               314    51.39%
Storages/tests/TiFlashStorageTestBasic.h            27                 5    81.48%           6                 0   100.00%          51                12    76.47%          18                 9    50.00%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                             3984              1474    63.00%         438               263    39.95%        3894              1999    48.66%        1810              1075    40.61%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16931      9505             43.86%    190876  96505        49.44%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 16, 2022

Coverage for changed files

Filename                                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/TiFlashMetrics.h                                 18                 0   100.00%          11                 0   100.00%          47                 1    97.87%           8                 0   100.00%
DataStreams/HashJoinProbeBlockInputStream.cpp           15                15     0.00%           4                 4     0.00%          28                28     0.00%          10                10     0.00%
DataStreams/HashJoinProbeBlockInputStream.h              1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp         390               390     0.00%          45                45     0.00%         875               875     0.00%         312               312     0.00%
Flash/Coprocessor/DAGUtils.cpp                         290               233    19.66%          36                24    33.33%         505               404    20.00%         324               230    29.01%
Flash/EstablishCall.h                                    2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
Flash/Mpp/MPPTunnel.cpp                                185               185     0.00%          16                16     0.00%         241               241     0.00%          94                94     0.00%
Flash/Mpp/MPPTunnel.h                                    9                 9     0.00%           9                 9     0.00%          18                18     0.00%           0                 0         -
Functions/FunctionsDateTime.cpp                         27                19    29.63%           4                 2    50.00%          99                25    74.75%          16                13    18.75%
Functions/FunctionsDateTime.h                         1073               638    40.54%         322               209    35.09%        2018              1226    39.25%         534               340    36.33%
Functions/tests/gtest_dayofweekyear.cpp                258                74    71.32%           2                 0   100.00%         135                 0   100.00%          80                42    47.50%
Storages/Page/V3/WAL/WALReader.cpp                      72                10    86.11%           9                 0   100.00%         176                15    91.48%          54                14    74.07%
Storages/Page/V3/WALStore.cpp                           74                39    47.30%           8                 1    87.50%         134                42    68.66%          36                19    47.22%
Storages/Page/V3/WALStore.h                              1                 0   100.00%           1                 0   100.00%           3                 0   100.00%           0                 0         -
Storages/Page/V3/tests/gtest_wal_store.cpp            1948               260    86.65%          12                 0   100.00%         465                13    97.20%         646               314    51.39%
Storages/tests/TiFlashStorageTestBasic.h                27                 5    81.48%           6                 0   100.00%          51                12    76.47%          18                 9    50.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                 4390              1880    57.18%         488               313    35.86%        4798              2903    39.50%        2132              1397    34.47%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16936      9510             43.85%    190905  96519        49.44%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 16, 2022

Coverage for changed files

Filename                                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/TiFlashMetrics.h                                 18                 0   100.00%          11                 0   100.00%          47                 1    97.87%           8                 0   100.00%
DataStreams/HashJoinProbeBlockInputStream.cpp           15                15     0.00%           4                 4     0.00%          28                28     0.00%          10                10     0.00%
DataStreams/HashJoinProbeBlockInputStream.h              1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp         390               390     0.00%          45                45     0.00%         875               875     0.00%         312               312     0.00%
Flash/Coprocessor/DAGUtils.cpp                         290               233    19.66%          36                24    33.33%         505               404    20.00%         324               230    29.01%
Flash/EstablishCall.h                                    2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
Flash/Mpp/MPPTunnel.cpp                                185               185     0.00%          16                16     0.00%         241               241     0.00%          94                94     0.00%
Flash/Mpp/MPPTunnel.h                                    9                 9     0.00%           9                 9     0.00%          18                18     0.00%           0                 0         -
Functions/FunctionsDateTime.cpp                         27                19    29.63%           4                 2    50.00%          99                25    74.75%          16                13    18.75%
Functions/FunctionsDateTime.h                         1073               638    40.54%         322               209    35.09%        2018              1226    39.25%         534               340    36.33%
Functions/tests/gtest_dayofweekyear.cpp                258                74    71.32%           2                 0   100.00%         135                 0   100.00%          80                42    47.50%
Storages/Page/V3/WAL/WALReader.cpp                      72                10    86.11%           9                 0   100.00%         176                15    91.48%          54                14    74.07%
Storages/Page/V3/WALStore.cpp                           74                39    47.30%           8                 1    87.50%         134                42    68.66%          36                19    47.22%
Storages/Page/V3/WALStore.h                              1                 0   100.00%           1                 0   100.00%           3                 0   100.00%           0                 0         -
Storages/Page/V3/tests/gtest_wal_store.cpp            1948               260    86.65%          12                 0   100.00%         465                13    97.20%         646               314    51.39%
Storages/tests/TiFlashStorageTestBasic.h                27                 5    81.48%           6                 0   100.00%          51                12    76.47%          18                 9    50.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                 4390              1880    57.18%         488               313    35.86%        4798              2903    39.50%        2132              1397    34.47%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16936      9510             43.85%    190905  96515        49.44%

full coverage report (for internal network access only)

@ti-chi-bot
Copy link
Member

@JinheLin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 16, 2022

Coverage for changed files

Filename                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/TiFlashMetrics.h                                      18                 0   100.00%          11                 0   100.00%          47                 1    97.87%           8                 0   100.00%
DataStreams/HashJoinProbeBlockInputStream.cpp                15                15     0.00%           4                 4     0.00%          28                28     0.00%          10                10     0.00%
DataStreams/HashJoinProbeBlockInputStream.h                   1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
DataStreams/ParallelAggregatingBlockInputStream.cpp          93                93     0.00%          12                12     0.00%         150               150     0.00%          64                64     0.00%
DataStreams/ParallelAggregatingBlockInputStream.h             6                 6     0.00%           6                 6     0.00%          14                14     0.00%           0                 0         -
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp              390               390     0.00%          45                45     0.00%         875               875     0.00%         312               312     0.00%
Flash/Coprocessor/DAGUtils.cpp                              290               233    19.66%          36                24    33.33%         505               404    20.00%         324               230    29.01%
Flash/EstablishCall.h                                         2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
Flash/Mpp/MPPTunnel.cpp                                     185               185     0.00%          16                16     0.00%         241               241     0.00%          94                94     0.00%
Flash/Mpp/MPPTunnel.h                                         9                 9     0.00%           9                 9     0.00%          18                18     0.00%           0                 0         -
Functions/FunctionsDateTime.cpp                              27                19    29.63%           4                 2    50.00%          99                25    74.75%          16                13    18.75%
Functions/FunctionsDateTime.h                              1073               638    40.54%         322               209    35.09%        2018              1226    39.25%         534               340    36.33%
Functions/tests/gtest_dayofweekyear.cpp                     258                74    71.32%           2                 0   100.00%         135                 0   100.00%          80                42    47.50%
Storages/Page/V3/WAL/WALReader.cpp                           72                10    86.11%           9                 0   100.00%         176                15    91.48%          54                14    74.07%
Storages/Page/V3/WALStore.cpp                                74                39    47.30%           8                 1    87.50%         134                42    68.66%          36                19    47.22%
Storages/Page/V3/WALStore.h                                   1                 0   100.00%           1                 0   100.00%           3                 0   100.00%           0                 0         -
Storages/Page/V3/tests/gtest_wal_store.cpp                 1948               260    86.65%          12                 0   100.00%         465                13    97.20%         646               314    51.39%
Storages/tests/TiFlashStorageTestBasic.h                     27                 5    81.48%           6                 0   100.00%          51                12    76.47%          18                 9    50.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                      4489              1979    55.91%         506               331    34.58%        4962              3067    38.19%        2196              1461    33.47%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16936      9510             43.85%    190908  96522        49.44%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 0e70f4f into pingcap:master Mar 16, 2022
@JaySon-Huang JaySon-Huang deleted the update-readme branch March 17, 2022 00:33
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants