-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the right way to wait tiflash replica ready in least_greatest.test #4317
Conversation
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can we modify the scripts to check syntax ? Someone else may make same mistake. |
/merge |
@windtalker: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 5e0e2ba
|
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
Yes, I think we need to improve this. |
Signed-off-by: xufei xufeixw@mail.ustc.edu.cn
What problem does this PR solve?
Issue Number: close #4316
Problem Summary:
As the issue described.
What is changed and how it works?
The root cause is
least_greatest.test
use a wrong way to wait tiflash replica ready, so actually the wait is timeout after 600 seconds.Check List
Tests
Side effects
Documentation
Release note