Fix broken ut SegmentDeletionRelevantPlaceTest #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
added
the
needs-rebase
JaySon-Huang
force-pushed
the
fix_broken_test
branch
from
7baf4c7
to
8f99e7f
Compare
ti-chi-bot
removed
the
needs-rebase
JaySon-Huang
force-pushed
the
fix_broken_test
branch
from
8f99e7f
to
229ac0f
Compare
|
/run-all-tests |
JaySon-Huang
force-pushed
the
fix_broken_test
branch
from
7cf8c1a
to
8330204
Compare
|
/run-all-tests |
JaySon-Huang
commented
Jun 1, 2022
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
JaySon-Huang
force-pushed
the
fix_broken_test
branch
from
fbbe076
to
35a8c2e
Compare
JaySon-Huang
commented
Jun 1, 2022
Comment on lines
-428
to
-438
| DB::Settings getSettings() | ||
| { | ||
| DB::Settings settings; | ||
| auto enable_relevant_place = GetParam(); | ||
|
|
||
| if (enable_relevant_place) | ||
| settings.set("dt_enable_relevant_place", "1"); | ||
| else | ||
| settings.set("dt_enable_relevant_place", "0"); | ||
| return settings; | ||
| } |
There was a problem hiding this comment.
This is a useless function that never called after #2415
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
lidezhu
reviewed
Jun 4, 2022
lidezhu
approved these changes
Jun 4, 2022
Co-authored-by: lidezhu <47731263+lidezhu@users.noreply.github.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
flowbehappy
approved these changes
Jun 6, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 2085bd6
|
ti-chi-bot
added
the
status/can-merge
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4606
Problem Summary:
After #2415
SegmentDeletionRelevantPlaceTest::getSettingsis not used at all, "SegmentDeletionRelevantPlaceTest" only run test with relevant_place with default value.What is changed and how it works?
relevant_placesettings byreloadCheck List
Tests
Side effects
Documentation
Release note