Revert "Fix getMaxId won't get the right max id before GC"

[jiaqizho]

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary: If getMaxId ignore the deleted entry, we will reuse the PageId after a restart, which break the assumption that we will never reuse a PageID after deleted.

What is changed and how it works?

Reverts #4838

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JaySon-Huang
• lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[JaySon-Huang]

LGTM

[jiaqizho]

/merge

[ti-chi-bot]

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: f8caef2

[sre-bot]

Coverage for changed files

Filename                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PageDirectory.cpp                      514                77    85.02%          31                 2    93.55%        1096               184    83.21%         400                92    77.00%
tests/gtest_page_directory.cpp        8833              1575    82.17%          50                 0   100.00%        1646                 7    99.57%        2774              1405    49.35%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                 9347              1652    82.33%          81                 2    97.53%        2742               191    93.03%        3174              1497    52.84%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18090      10149            43.90%    200943  100968       49.75%

full coverage report (for internal network access only)