Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TiFlash proxy #4907

Merged
merged 3 commits into from
May 17, 2022
Merged

update TiFlash proxy #4907

merged 3 commits into from
May 17, 2022

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented May 17, 2022

Signed-off-by: CalvinNeo calvinneo1995@gmail.com

What problem does this PR solve?

Issue Number: close #4906

Problem Summary:
Current version of proxy merges TiKV 6.0. Some TiKV code will modify store_stats after it is reported by handle_compute_store_stats.
These modification shall be disabled, since store status on TiFlash side rather than Proxy's side matters.

What is changed and how it works?

Disable newly added code by TiKV.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 17, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jiaqizho
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2022
@jiaqizho
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 16ee252

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2022
@CalvinNeo
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@CalvinNeo: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CalvinNeo
Copy link
Member Author

/rebuild

@CalvinNeo
Copy link
Member Author

/run-integration-test

@JaySon-Huang
Copy link
Contributor

Seems that there is compile error for proxy code?
https://github.com/pingcap/tidb-engine-ext/runs/6464382882?check_suite_focus=true

error[E0425]: cannot find value `used_size` in this scope
    --> components/raftstore/src/store/worker/pd.rs:1115:18
     |
1115 |             .set(used_size as i64);
     |                  ^^^^^^^^^ not found in this scope

    Checking tidb_query_aggr v0.0.1 (/home/runner/work/tidb-engine-ext/tidb-engine-ext/components/tidb_query_aggr)
    Checking tidb_query_executors v0.0.1 (/home/runner/work/tidb-engine-ext/tidb-engine-ext/components/tidb_query_executors)
warning: unused import: `ImportExt`
  --> components/raftstore/src/store/snap/io.rs:12:57
   |
12 |     CfName, EncryptionKeyManager, Error as EngineError, ImportExt, IngestExternalFileOptions,
   |                                                         ^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused import: `IngestExternalFileOptions`
  --> components/raftstore/src/store/snap/io.rs:12:68
   |
12 |     CfName, EncryptionKeyManager, Error as EngineError, ImportExt, IngestExternalFileOptions,
   |                                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0[425](https://github.com/pingcap/tidb-engine-ext/runs/6464382882?check_suite_focus=true#step:6:425)`.
warning: `raftstore` (lib) generated 2 warnings
error: could not compile `raftstore` due to previous error; 2 warnings emitted

@CalvinNeo CalvinNeo changed the title update update TiFlash proxy May 17, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented May 17, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18141      9786             46.06%    202435  97908        51.63%

full coverage report (for internal network access only)

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2022
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@CalvinNeo: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7648968

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2022
@ti-chi-bot
Copy link
Member

@CalvinNeo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 17, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18154      9788             46.08%    202633  97910        51.68%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 1c08068 into pingcap:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PD store usage not right in master.
6 participants