Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: check Overflow int128 (#4762) #4944

Closed
wants to merge 9 commits into from
Closed

expression: check Overflow int128 (#4762) #4944

wants to merge 9 commits into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4762

What problem does this PR solve?

Issue Number: close #4512

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@fzhedu @ti-chi-bot
justify whether overflow int128
467d82e 
Signed-off-by: fzhedu <fzhedu@gmail.com>
@fzhedu @ti-chi-bot
refactor and add tests
ed6b3b0
@fzhedu @ti-chi-bot
add gtest for mul128 mul256 overflow
a262c86 
Signed-off-by: fzhedu <fzhedu@gmail.com>
@fzhedu @ti-chi-bot
add gtest for mul128 mul256 overflow
9e20e61 
Signed-off-by: fzhedu <fzhedu@gmail.com>
@fzhedu @ti-chi-bot
add gtest for mul128 mul256 overflow
5966d4c 
Signed-off-by: fzhedu <fzhedu@gmail.com>
@fzhedu @ti-chi-bot
make sure the int256
e2f0de5 
Signed-off-by: fzhedu <fzhedu@gmail.com>
@fzhedu @ti-chi-bot
add commets to mulOverflow
0289460 
Signed-off-by: fzhedu <fzhedu@gmail.com>
@fzhedu @ti-chi-bot
formated
dbb9228 
Signed-off-by: fzhedu <fzhedu@gmail.com>
@fzhedu @ti-chi-bot
formated
707f0e3 
Signed-off-by: fzhedu <fzhedu@gmail.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fzhedu
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 20, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 20, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.0 labels May 20, 2022
fzhedu
fzhedu approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 15, 2022
@fzhedu
Copy link
Contributor

fzhedu commented Jun 15, 2022

/rebuild

windtalker
windtalker approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 15, 2022
@zanmato1984
Copy link
Contributor

We don't back port any PR into release-6.0. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzhedu fzhedu fzhedu approved these changes

@windtalker windtalker windtalker approved these changes

Assignees

@fzhedu fzhedu

Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @fzhedu @zanmato1984 @windtalker