Schedule: track the waiting tasks with task ID, and deleted the scheduled task with exceeded state from the waiting tasks queue (#4958)

[ti-chi-bot]

This is an automated cherry-pick of #4958

… queue

Signed-off-by: fzhedu fzhedu@gmail.com

What problem does this PR solve?

Issue Number: close #4954

Problem Summary:
It is a rule that the lifecycle of a task in the minTSO schedule should be covered by the taskManager.
However, the scheduled tasks due to exceeding the hard limit are not removed from the waiting task queue of the schedule, but will ungester from the taskManager, so the waiting task queue hold the last reference of the task, which break the rule.

to fundamentally prevent from the probem above, we track the waiting tasks with its task ID.

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• fzhedu
• windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[fzhedu]

LGTM

[windtalker]

LGTM

[fzhedu]

/merge

[ti-chi-bot]

@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 86b151e

[sre-bot]

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
MPPTaskManager.h                    1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
MinTSOScheduler.cpp               317               284    10.41%           7                 6    14.29%         193               171    11.40%         162               157     3.09%
MinTSOScheduler.h                   4                 1    75.00%           2                 0   100.00%           4                 0   100.00%           4                 3    25.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             322               285    11.49%          10                 6    40.00%         198               171    13.64%         166               160     3.61%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18222      9784             46.31%    204110  97951        52.01%

full coverage report (for internal network access only)