Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize blobstore gc when current stat total size is 0 #5015

Merged
merged 9 commits into from
May 27, 2022
Merged

Optimize blobstore gc when current stat total size is 0 #5015

merged 9 commits into from
May 27, 2022

Conversation

jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented May 27, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5016

Problem Summary:

  • After restore, the size of snapshot will be 0, Then some of the total size from blobstat will get 0.
  • But the blob file size in disk may not be 0.

What is changed and how it works?

  • Truncate the blob file size.
  • Also update valid rate to 0 is total size is 0.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2022
JaySon-Huang
JaySon-Huang approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small comments

Use "0.0" indicate it is double type
Take care of the param of LOG_FMT

dbms/src/Storages/Page/V3/BlobStore.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Page/V3/BlobStore.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Page/V3/BlobStore.h Outdated Show resolved Hide resolved
dbms/src/Storages/Page/V3/BlobStore.cpp Outdated Show resolved Hide resolved
@jiaqizho jiaqizho added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-triage-completed labels May 27, 2022
@jiaqizho @JaySon-Huang
Update dbms/src/Storages/Page/V3/BlobStore.cpp
2a1d161 
Co-authored-by: JaySon <tshent@qq.com>
jiaqizho and others added 3 commits May 27, 2022 14:05
@jiaqizho @JaySon-Huang
Update dbms/src/Storages/Page/V3/BlobStore.cpp
51401f1 
Co-authored-by: JaySon <tshent@qq.com>
@jiaqizho @JaySon-Huang
Update dbms/src/Storages/Page/V3/BlobStore.h
581d09f 
Co-authored-by: JaySon <tshent@qq.com>
@jiaqizho @JaySon-Huang
Update dbms/src/Storages/Page/V3/BlobStore.cpp
325519a 
Co-authored-by: JaySon <tshent@qq.com>
@jiaqizho
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented May 27, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
BlobStore.cpp                     573               146    74.52%          53                 1    98.11%        1140               227    80.09%         360               125    65.28%
BlobStore.h                        10                 2    80.00%          10                 2    80.00%          46                23    50.00%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             583               148    74.61%          63                 3    95.24%        1186               250    78.92%         360               125    65.28%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18266      9777             46.47%    204612  97974        52.12%

full coverage report (for internal network access only)

CalvinNeo
CalvinNeo approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2022
@jiaqizho
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 325519a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@jiaqizho
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2022
@jiaqizho
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2022
@jiaqizho
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d8fcb78

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@ti-chi-bot
Copy link
Member

@jiaqizho: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@jiaqizho @flowbehappy
Update dbms/src/Storages/Page/V3/BlobStore.cpp
2b55f53 
Co-authored-by: Flowyi <flowbehappy@gmail.com>
@jiaqizho
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 27, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
BlobStore.cpp                     577               147    74.52%          53                 1    98.11%        1146               233    79.67%         362               126    65.19%
BlobStore.h                        10                 2    80.00%          10                 2    80.00%          46                23    50.00%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             587               149    74.62%          63                 3    95.24%        1192               256    78.52%         362               126    65.19%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18277      9785             46.46%    204795  98115        52.09%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit d84f273 into pingcap:master May 27, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 27, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5019.

ti-chi-bot added a commit that referenced this pull request May 27, 2022
@ti-chi-bot
Optimize blobstore gc when current stat total size is 0 (#5015) (#5019)
f267466 
close #5016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowbehappy flowbehappy flowbehappy left review comments

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@hehechen hehechen Awaiting requested review from hehechen

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blob may not cleanup after restore.
6 participants
@jiaqizho @ti-chi-bot @sre-bot @flowbehappy @JaySon-Huang @CalvinNeo