Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix invalid fmt format string in CreatingSetsBlockInputStream.cpp #5053

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Jun 2, 2022

What problem does this PR solve?

Issue Number: ref #5052

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Jun 2, 2022
@ywqzzy ywqzzy requested a review from SeaRise June 2, 2022 06:58
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 2, 2022
@ywqzzy ywqzzy requested a review from windtalker June 2, 2022 07:01
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-triage-completed labels Jun 2, 2022
@ywqzzy ywqzzy removed the needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 label Jun 2, 2022
@ywqzzy ywqzzy removed the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 2, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jun 2, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jun 2, 2022

Coverage for changed files

Filename                                                                                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/DataStreams/CreatingSetsBlockInputStream.cpp         188               181     3.72%          11                 9    18.18%         213               196     7.98%         118               112     5.08%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                    188               181     3.72%          11                 9    18.18%         213               196     7.98%         118               112     5.08%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18282      9734             46.76%    204983  97614        52.38%

full coverage report (for internal network access only)

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jun 2, 2022

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: db763db

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jun 2, 2022

Coverage for changed files

Filename                                                                                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/DataStreams/CreatingSetsBlockInputStream.cpp         188               181     3.72%          11                 9    18.18%         213               196     7.98%         118               112     5.08%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                    188               181     3.72%          11                 9    18.18%         213               196     7.98%         118               112     5.08%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18282      9734             46.76%    204983  97600        52.39%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 20d2198 into pingcap:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants