Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flush cache before segment merge #5289

Merged
merged 6 commits into from
Jul 6, 2022
Merged

flush cache before segment merge #5289

merged 6 commits into from
Jul 6, 2022

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Jul 5, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: cherry pick of #4955

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@lidezhu
This is an automated cherry-pick of pingcap#4955
0a4a29b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@lidezhu
Update DeltaMergeStore.cpp
e996a1c
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 5, 2022
@lidezhu lidezhu added the CHERRY-PICK cherry pick label Jul 5, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 5, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 5, 2022

/rebuild

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 5, 2022

/rebuild

2 similar comments
@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 5, 2022

/rebuild

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 5, 2022

/rebuild

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 5, 2022

/run-all-tests

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 5, 2022

/run-unit-test

3 similar comments
@SchrodingerZhu
Copy link
Contributor

/run-unit-test

@SchrodingerZhu
Copy link
Contributor

/run-unit-test

@SchrodingerZhu
Copy link
Contributor

/run-unit-test

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 6, 2022

/run-unit-test

1 similar comment
@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 6, 2022

/run-unit-test

@SchrodingerZhu
Copy link
Contributor

/run-unit-test

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 6, 2022

unit test succeed in https://ci.pingcap.net/job/tiflash-ghpr-unit-tests/4409/console

@lidezhu lidezhu merged commit d9d9ff9 into pingcap:release-4.0-20220429 Jul 6, 2022
@lidezhu lidezhu deleted the cherry-pick-4.0-2 branch July 6, 2022 03:46
@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 6, 2022

/run-integration-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CHERRY-PICK cherry pick cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lidezhu @ti-chi-bot @SchrodingerZhu @sre-bot