*: improve RUNTIME_CHECK and RUNTIME_ASSERT #5434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-linked-issue
release-note-none
|
@fuzhe1989: GitHub didn't allow me to request PR reviews from the following users: SchrodingerZhu. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @gengliqi |
|
/run-all-tests |
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/run-integration-test |
|
/run-unit-test |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
any update? @JaySon-Huang @SeaRise @gengliqi |
gengliqi
reviewed
Jul 25, 2022
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
gengliqi
reviewed
Jul 26, 2022
dbms/src/Common/Exception.h
Outdated
| } | ||
|
|
||
| template <typename... Args> | ||
| inline void log(const char * filename, int lineno, const char * condition, const LoggerPtr & logger, const char * fmt_str, Args &&... args) |
There was a problem hiding this comment.
How about removing const char * fmt_str?
If so, inline void log(const char * filename, int lineno, const char * condition, const LoggerPtr & logger) can be removed too.
| } | ||
|
|
||
| template <typename... Args> | ||
| inline void log(const char * filename, int lineno, const char * condition, const char * fmt_str, Args &&... args) |
There was a problem hiding this comment.
this fmt_str is used for overloadding from const LoggerPtr & or this version will always be chosen even when there's a const LoggerPtr &.
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
gengliqi
approved these changes
Jul 26, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 709cd71
|
ti-chi-bot
added
the
status/can-merge
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/merge |
|
@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
12 tasks
JaySon-Huang
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Aug 31, 2022
close pingcap#5444 Conflicts: dbms/src/Common/FailPoint.cpp dbms/src/Common/FailPoint.h dbms/src/Flash/Coprocessor/DAGQueryBlockInterpreter.cpp dbms/src/Flash/Mpp/ExchangeReceiver.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: fuzhe1989 fuzhe1989@gmail.com
What problem does this PR solve?
Issue Number: close #5444
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note