*: Simplify join executor translation #5453

Willendless · 2022-07-22T22:55:57Z

What problem does this PR solve?

Issue Number: ref #5351

Problem Summary:

For detailed design consideration, please refer to #5351.

What is changed and how it works?

update join executor test API from ASTTableJoin::Kind to tipb::JoinType
update relevant tests accordingly

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2022-07-22T22:55:59Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

SeaRise
ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Willendless · 2022-07-22T23:02:16Z

/run-unit-test

sre-bot · 2022-07-22T23:19:22Z

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/astToExecutor.cpp                          577               142    75.39%          54                 4    92.59%        1532               363    76.31%         574               193    66.38%
Debug/astToExecutor.h                             30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Flash/tests/gtest_interpreter.cpp                194               114    41.24%           7                 0   100.00%         557                 0   100.00%          24                24     0.00%
Flash/tests/gtest_join_executor.cpp              334               231    30.84%          16                 0   100.00%         271                 0   100.00%          60                51    15.00%
Flash/tests/gtest_split_tasks.cpp                 67                38    43.28%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                        76                 4    94.74%          43                 2    95.35%         276                27    90.22%          38                 2    94.74%
TestUtils/mockExecutor.h                           6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp         262               190    27.48%          11                 0   100.00%         215                 0   100.00%          40                40     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                           1546               728    52.91%         162                11    93.21%        3014               405    86.56%         760               323    57.50%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18778      9448             49.69%    213937  95473        55.37%

full coverage report (for internal network access only)

dbms/src/Debug/astToExecutor.h

Willendless · 2022-07-26T21:00:56Z

/run-all-tests

sre-bot · 2022-07-26T21:17:58Z

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/astToExecutor.cpp                          586               142    75.77%          54                 4    92.59%        1540               363    76.43%         582               193    66.84%
Debug/astToExecutor.h                             30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Flash/tests/gtest_interpreter.cpp                194               114    41.24%           7                 0   100.00%         557                 0   100.00%          24                24     0.00%
Flash/tests/gtest_join_executor.cpp              202               136    32.67%          11                 0   100.00%         279                 0   100.00%          46                31    32.61%
Flash/tests/gtest_split_tasks.cpp                 67                38    43.28%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                        76                 4    94.74%          43                 2    95.35%         276                27    90.22%          38                 2    94.74%
TestUtils/mockExecutor.h                           6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp         262               190    27.48%          11                 0   100.00%         215                 0   100.00%          40                40     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                           1423               633    55.52%         157                11    92.99%        3030               405    86.63%         754               303    59.81%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18774      9441             49.71%    213946  95364        55.43%

full coverage report (for internal network access only)

Willendless · 2022-07-26T21:33:52Z

/run-all-tests

Willendless · 2022-07-26T21:54:06Z

/run-unit-test

Willendless · 2022-07-26T23:45:28Z

/run-all-tests

sre-bot · 2022-07-27T00:02:50Z

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/astToExecutor.cpp                          586               142    75.77%          54                 4    92.59%        1540               363    76.43%         582               193    66.84%
Debug/astToExecutor.h                             30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Flash/tests/gtest_collation.cpp                  280                82    70.71%          10                 0   100.00%         349                57    83.67%         124                48    61.29%
Flash/tests/gtest_interpreter.cpp                194               114    41.24%           7                 0   100.00%         557                 0   100.00%          24                24     0.00%
Flash/tests/gtest_join_executor.cpp              202               136    32.67%          11                 0   100.00%         279                 0   100.00%          46                31    32.61%
Flash/tests/gtest_split_tasks.cpp                 67                38    43.28%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                        76                 4    94.74%          43                 2    95.35%         276                27    90.22%          38                 2    94.74%
TestUtils/mockExecutor.h                          11                 4    63.64%          11                 4    63.64%          23                 6    73.91%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp         262               190    27.48%          11                 0   100.00%         215                 0   100.00%          40                40     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                           1708               718    57.96%         172                14    91.86%        3387               465    86.27%         878               351    60.02%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18821      9427             49.91%    214643  95286        55.61%

full coverage report (for internal network access only)

Willendless · 2022-07-27T17:35:41Z

/run-all-tests

sre-bot · 2022-07-27T17:53:04Z

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/astToExecutor.cpp                           584               140    76.03%          57                 3    94.74%        1551               358    76.92%         578               191    66.96%
Debug/astToExecutor.h                              30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Flash/Coprocessor/JoinInterpreterHelper.h          28                 4    85.71%           8                 0   100.00%          16                 0   100.00%          22                 5    77.27%
Flash/tests/gtest_collation.cpp                   280                82    70.71%          10                 0   100.00%         349                57    83.67%         124                48    61.29%
Flash/tests/gtest_interpreter.cpp                 194               114    41.24%           7                 0   100.00%         557                 0   100.00%          24                24     0.00%
Flash/tests/gtest_join_executor.cpp               201               136    32.34%          10                 0   100.00%         279                 0   100.00%          46                31    32.61%
Flash/tests/gtest_split_tasks.cpp                  67                38    43.28%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                         76                 4    94.74%          43                 2    95.35%         276                27    90.22%          38                 2    94.74%
TestUtils/mockExecutor.h                           11                 4    63.64%          11                 4    63.64%          23                 6    73.91%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp          262               190    27.48%          11                 0   100.00%         215                 0   100.00%          40                40     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            1733               720    58.45%         182                13    92.86%        3414               460    86.53%         896               354    60.49%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18820      9427             49.91%    214643  95279        55.61%

full coverage report (for internal network access only)

SeaRise · 2022-07-28T18:14:05Z

dbms/src/Flash/tests/gtest_join_executor.cpp

+        {toNullableVec<String>({"1", "2", {}, "1", {}}), toNullableVec<String>({"3", "4", "3", {}, {}}), toNullableVec<String>({"0", "1", "1", "0", "1"})},
+        {toNullableVec<String>({"1", "3", {}, "1", {}}), toNullableVec<String>({"3", "4", "3", {}, {}}), toNullableVec<String>({"0", "1", "1", "0", "1"})},
+        {toNullableVec<String>({"1", "2", {}, "1", {}}), toNullableVec<String>({"3", "4", "3", {}, {}}), toNullableVec<String>({"0", "0", "0", "1", "1"})},
+        {toNullableVec<String>({"1", "3", {}, "1", {}}), toNullableVec<String>({"3", "4", "3", {}, {}}), toNullableVec<String>({"0", "0", "0", "1", "1"})},


Why is the data type of match_helper_column not UInt8?

tiflash/dbms/src/Interpreters/Join.cpp

Line 112 in 245e2fb

const DataTypePtr Join::match_helper_type = makeNullable(std::make_shared<DataTypeInt8>());

Same confusion while writing the tests. Let me look into it.

Problem fixed.

…i join

Willendless · 2022-07-29T00:30:07Z

/run-all-tests

sre-bot · 2022-07-29T00:46:50Z

Coverage for changed files

Filename                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/astToExecutor.cpp                               584               140    76.03%          57                 3    94.74%        1550               358    76.90%         578               191    66.96%
Debug/astToExecutor.h                                  30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Flash/Coprocessor/JoinInterpreterHelper.h              28                 4    85.71%           8                 0   100.00%          16                 0   100.00%          22                 5    77.27%
Flash/Coprocessor/collectOutputFieldTypes.cpp          64                 6    90.62%          14                 0   100.00%         154                12    92.21%          60                 7    88.33%
Flash/tests/gtest_collation.cpp                       280                82    70.71%          10                 0   100.00%         349                57    83.67%         124                48    61.29%
Flash/tests/gtest_interpreter.cpp                     194               114    41.24%           7                 0   100.00%         557                 0   100.00%          24                24     0.00%
Flash/tests/gtest_join_executor.cpp                   201               136    32.34%          10                 0   100.00%         279                 0   100.00%          46                31    32.61%
Flash/tests/gtest_split_tasks.cpp                      67                38    43.28%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                             76                 4    94.74%          43                 2    95.35%         276                27    90.22%          38                 2    94.74%
TestUtils/mockExecutor.h                               11                 4    63.64%          11                 4    63.64%          23                 6    73.91%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp              262               190    27.48%          11                 0   100.00%         215                 0   100.00%          40                40     0.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                1797               726    59.60%         196                13    93.37%        3567               472    86.77%         956               361    62.24%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18820      9427             49.91%    214654  95284        55.61%

full coverage report (for internal network access only)

SeaRise

LGTM

Willendless · 2022-07-29T03:50:03Z

/run-all-tests

ywqzzy

LGTM

sre-bot · 2022-07-29T04:08:16Z

Coverage for changed files

Filename                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/astToExecutor.cpp                               584               141    75.86%          57                 4    92.98%        1556               363    76.67%         578               191    66.96%
Debug/astToExecutor.h                                  30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Flash/Coprocessor/JoinInterpreterHelper.h              28                 4    85.71%           8                 0   100.00%          16                 0   100.00%          22                 5    77.27%
Flash/Coprocessor/collectOutputFieldTypes.cpp          64                 6    90.62%          14                 0   100.00%         154                12    92.21%          60                 7    88.33%
Flash/tests/gtest_collation.cpp                       280                82    70.71%          10                 0   100.00%         349                57    83.67%         124                48    61.29%
Flash/tests/gtest_interpreter.cpp                     194               114    41.24%           7                 0   100.00%         557                 0   100.00%          24                24     0.00%
Flash/tests/gtest_join_executor.cpp                   201               136    32.34%          10                 0   100.00%         279                 0   100.00%          46                31    32.61%
Flash/tests/gtest_split_tasks.cpp                      67                38    43.28%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                             76                 4    94.74%          43                 2    95.35%         276                27    90.22%          38                 2    94.74%
TestUtils/mockExecutor.h                               11                 4    63.64%          11                 4    63.64%          23                 6    73.91%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp              262               190    27.48%          11                 0   100.00%         215                 0   100.00%          40                40     0.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                1797               727    59.54%         196                14    92.86%        3573               477    86.65%         956               361    62.24%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18820      9427             49.91%    214654  95268        55.62%

full coverage report (for internal network access only)

SeaRise · 2022-07-29T04:33:15Z

/merge

ti-chi-bot · 2022-07-29T04:33:16Z

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-07-29T04:33:17Z

This pull request has been accepted and is ready to merge.

Commit hash: c492177

ti-chi-bot · 2022-07-29T04:33:30Z

@Willendless: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sre-bot · 2022-07-29T04:45:47Z

Coverage for changed files

Filename                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/astToExecutor.cpp                               584               141    75.86%          57                 4    92.98%        1556               363    76.67%         578               191    66.96%
Debug/astToExecutor.h                                  30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Flash/Coprocessor/JoinInterpreterHelper.h              28                 4    85.71%           8                 0   100.00%          16                 0   100.00%          22                 5    77.27%
Flash/Coprocessor/collectOutputFieldTypes.cpp          64                 6    90.62%          14                 0   100.00%         154                12    92.21%          60                 7    88.33%
Flash/tests/gtest_collation.cpp                       280                82    70.71%          10                 0   100.00%         349                57    83.67%         124                48    61.29%
Flash/tests/gtest_interpreter.cpp                     194               114    41.24%           7                 0   100.00%         557                 0   100.00%          24                24     0.00%
Flash/tests/gtest_join_executor.cpp                   201               136    32.34%          10                 0   100.00%         279                 0   100.00%          46                31    32.61%
Flash/tests/gtest_split_tasks.cpp                      67                38    43.28%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                             76                 4    94.74%          43                 2    95.35%         276                27    90.22%          38                 2    94.74%
TestUtils/mockExecutor.h                               11                 4    63.64%          11                 4    63.64%          23                 6    73.91%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp              262               190    27.48%          11                 0   100.00%         215                 0   100.00%          40                40     0.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                1797               727    59.54%         196                14    92.86%        3573               477    86.65%         956               361    62.24%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18820      9428             49.90%    214654  95319        55.59%

full coverage report (for internal network access only)

sre-bot · 2022-07-29T04:52:00Z

Coverage for changed files

Filename                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/astToExecutor.cpp                               584               141    75.86%          57                 4    92.98%        1556               363    76.67%         578               191    66.96%
Debug/astToExecutor.h                                  30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Flash/Coprocessor/JoinInterpreterHelper.h              28                 4    85.71%           8                 0   100.00%          16                 0   100.00%          22                 5    77.27%
Flash/Coprocessor/collectOutputFieldTypes.cpp          64                 6    90.62%          14                 0   100.00%         154                12    92.21%          60                 7    88.33%
Flash/tests/gtest_collation.cpp                       125                37    70.40%          10                 0   100.00%         349                57    83.67%          82                28    65.85%
Flash/tests/gtest_interpreter.cpp                     122                42    65.57%           7                 0   100.00%         557                 0   100.00%          24                24     0.00%
Flash/tests/gtest_join_executor.cpp                   101                49    51.49%          10                 0   100.00%         279                 0   100.00%          40                28    30.00%
Flash/tests/gtest_split_tasks.cpp                      43                14    67.44%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                             76                 4    94.74%          43                 2    95.35%         276                27    90.22%          38                 2    94.74%
TestUtils/mockExecutor.h                               11                 4    63.64%          11                 4    63.64%          23                 6    73.91%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp              142                70    50.70%          11                 0   100.00%         215                 0   100.00%          40                40     0.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                1326               379    71.42%         196                14    92.86%        3573               477    86.65%         908               338    62.78%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18861      9432             49.99%    214999  95320        55.66%

full coverage report (for internal network access only)

Willendless added 2 commits July 22, 2022 18:50

feat: simplify join executor translation

98cb45e

chore: format

d23c265

ywqzzy self-requested a review July 25, 2022 02:24

ywqzzy reviewed Jul 25, 2022

View reviewed changes

dbms/src/Debug/astToExecutor.h Show resolved Hide resolved

feat: support testing semi join

75f40eb

ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 25, 2022

chore: enhance join simple tests

1e5d52e

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2022

feat: enhance all tests

077252a

Willendless changed the title ~~[WIP] *: Simplify join executor translation~~ *: Simplify join executor translation Jul 26, 2022

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2022

chore: resolve conflict

8c8510e

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2022

chore: use tipb join type for collation test

2249082

ywqzzy self-requested a review July 27, 2022 02:01

Willendless added 2 commits July 27, 2022 11:54

fix: resolve comment typo

7b4c9ba

chore: refine join executor construction code

c7919c2

SeaRise reviewed Jul 28, 2022

View reviewed changes

Willendless added 4 commits July 28, 2022 20:06

fix: resolve additional column field_type for (anti) lefter outer sem…

6ce8bcd

…i join

chore: update joio unit tests

a4cc2f2

chore: format

11fa721

chore: remove useless headers

f0a99c3

SeaRise self-requested a review July 29, 2022 02:20

SeaRise approved these changes Jul 29, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2022

fix: use correct field type for left outer semi joins additional column

c492177

ywqzzy approved these changes Jul 29, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2022

Merge branch 'master' into simplify-join-executor-translation

4095bb2

ti-chi-bot merged commit 5c54e9c into pingcap:master Jul 29, 2022

Willendless deleted the simplify-join-executor-translation branch July 29, 2022 18:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: Simplify join executor translation #5453

*: Simplify join executor translation #5453

Willendless commented Jul 22, 2022 •

edited

Loading

ti-chi-bot commented Jul 22, 2022 •

edited

Loading

Willendless commented Jul 22, 2022

sre-bot commented Jul 22, 2022

Willendless commented Jul 26, 2022

sre-bot commented Jul 26, 2022

Willendless commented Jul 26, 2022

Willendless commented Jul 26, 2022

Willendless commented Jul 26, 2022

sre-bot commented Jul 27, 2022

Willendless commented Jul 27, 2022

sre-bot commented Jul 27, 2022

SeaRise Jul 28, 2022

Willendless Jul 28, 2022 •

edited

Loading

Willendless Jul 29, 2022

Willendless commented Jul 29, 2022

sre-bot commented Jul 29, 2022

SeaRise left a comment

Willendless commented Jul 29, 2022

ywqzzy left a comment

sre-bot commented Jul 29, 2022

SeaRise commented Jul 29, 2022

ti-chi-bot commented Jul 29, 2022

ti-chi-bot commented Jul 29, 2022

ti-chi-bot commented Jul 29, 2022

sre-bot commented Jul 29, 2022

sre-bot commented Jul 29, 2022

*: Simplify join executor translation #5453

*: Simplify join executor translation #5453

Conversation

Willendless commented Jul 22, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Jul 22, 2022 • edited Loading

Willendless commented Jul 22, 2022

sre-bot commented Jul 22, 2022

Coverage for changed files

Coverage summary

Willendless commented Jul 26, 2022

sre-bot commented Jul 26, 2022

Coverage for changed files

Coverage summary

Willendless commented Jul 26, 2022

Willendless commented Jul 26, 2022

Willendless commented Jul 26, 2022

sre-bot commented Jul 27, 2022

Coverage for changed files

Coverage summary

Willendless commented Jul 27, 2022

sre-bot commented Jul 27, 2022

Coverage for changed files

Coverage summary

SeaRise Jul 28, 2022

Choose a reason for hiding this comment

Willendless Jul 28, 2022 • edited Loading

Choose a reason for hiding this comment

Willendless Jul 29, 2022

Choose a reason for hiding this comment

Willendless commented Jul 29, 2022

sre-bot commented Jul 29, 2022

Coverage for changed files

Coverage summary

SeaRise left a comment

Choose a reason for hiding this comment

Willendless commented Jul 29, 2022

ywqzzy left a comment

Choose a reason for hiding this comment

sre-bot commented Jul 29, 2022

Coverage for changed files

Coverage summary

SeaRise commented Jul 29, 2022

ti-chi-bot commented Jul 29, 2022

ti-chi-bot commented Jul 29, 2022

ti-chi-bot commented Jul 29, 2022

sre-bot commented Jul 29, 2022

Coverage for changed files

Coverage summary

sre-bot commented Jul 29, 2022

Coverage for changed files

Coverage summary

Willendless commented Jul 22, 2022 •

edited

Loading

ti-chi-bot commented Jul 22, 2022 •

edited

Loading

Willendless Jul 28, 2022 •

edited

Loading