Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo of Metrics #5472

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Fix typo of Metrics #5472

merged 2 commits into from
Jul 27, 2022

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Jul 26, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5473

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • Lloyd-Pottiger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2022
@JinheLin
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 26, 2022

Coverage for changed files

Filename                                                                                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Common/TiFlashMetrics.h          18                 0   100.00%          11                 0   100.00%          47                 1    97.87%           8                 0   100.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                18                 0   100.00%          11                 0   100.00%          47                 1    97.87%           8                 0   100.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18827      9437             49.88%    214683  95441        55.54%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2022
JaySon-Huang
JaySon-Huang approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If you need to make it cherry-picked to release-6.2 branch, you should create an issue and make the issue to be traige approved

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. do-not-merge/needs-triage-completed and removed status/LGT1 Indicates that a PR has LGTM 1. do-not-merge/needs-linked-issue labels Jul 26, 2022
@JinheLin
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1e97a4a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 27, 2022

Coverage for changed files

Filename                                                                                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Common/TiFlashMetrics.h          18                 0   100.00%          11                 0   100.00%          47                 1    97.87%           8                 0   100.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                18                 0   100.00%          11                 0   100.00%          47                 1    97.87%           8                 0   100.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18827      9438             49.87%    214683  95431        55.55%

full coverage report (for internal network access only)

@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 27, 2022

Coverage for changed files

Filename                                                                                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Common/TiFlashMetrics.h          18                 0   100.00%          11                 0   100.00%          47                 1    97.87%           8                 0   100.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                18                 0   100.00%          11                 0   100.00%          47                 1    97.87%           8                 0   100.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18827      9436             49.88%    214682  95429        55.55%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 53e2c42 into pingcap:master Jul 27, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 27, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5474.

ti-chi-bot added a commit that referenced this pull request Jul 27, 2022
@ti-chi-bot
Fix typo of Metrics (#5472) (#5474)
6970c2b 
close #5473
@JinheLin JinheLin deleted the fix_typo branch August 4, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@hehechen hehechen Awaiting requested review from hehechen

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.2 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in TiFlashMetrics
5 participants
@JinheLin @ti-chi-bot @sre-bot @JaySon-Huang @Lloyd-Pottiger