Improve performance of number comparison functions

[Lloyd-Pottiger]

What problem does this PR solve?

Issue Number: ref #5672

Problem Summary:

What is changed and how it works?

using dynamic dispatch
port from ClickHouse/ClickHouse#37399

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Result

--before
mysql > select c_name, c_custkey, o_orderkey, o_orderdate, o_totalprice, sum(l_quantity) from CUSTOMER, ORDERS, LINEITEM where o_orderkey in (         select l_orderkey         from LINEITEM
  group by l_orderkey         having sum(l_quantity) > 314     )     and c_custkey = o_custkey     and o_orderkey = l_orderkey group by c_name, c_custkey, o_orderkey, o_orderdate, o_totalprice order by o_totalprice desc, o_orderdate limit 100;
+--------------------+-----------+------------+-------------+--------------+-----------------+
| c_name             | c_custkey | o_orderkey | o_orderdate | o_totalprice | sum(l_quantity) |
+--------------------+-----------+------------+-------------+--------------+-----------------+
| Customer#000128120 |    128120 |    4722021 | 1994-04-07  |    544089.09 |          323.00 |
| Customer#000144617 |    144617 |    3043270 | 1997-02-12  |    530604.44 |          317.00 |
| Customer#000066790 |     66790 |    2199712 | 1996-09-30  |    515531.82 |          327.00 |
| Customer#000015619 |     15619 |    3767271 | 1996-08-07  |    480083.96 |          318.00 |
| Customer#000147197 |    147197 |    1263015 | 1997-02-02  |    467149.67 |          320.00 |
| Customer#000117919 |    117919 |    2869152 | 1996-06-20  |    456815.92 |          317.00 |
| Customer#000126865 |    126865 |    4702759 | 1994-11-07  |    447606.65 |          320.00 |
| Customer#000036619 |     36619 |    4806726 | 1995-01-17  |    446704.09 |          328.00 |
| Customer#000119989 |    119989 |    1544643 | 1997-09-20  |    434568.25 |          320.00 |
+--------------------+-----------+------------+-------------+--------------+-----------------+
9 rows in set (4.40 sec)

-- after 
mysql > select c_name, c_custkey, o_orderkey, o_orderdate, o_totalprice, sum(l_quantity) from CUSTOMER, ORDERS, LINEITEM where o_orderkey in (         select l_orderkey         from LINEITEM
  group by l_orderkey         having sum(l_quantity) > 314     )     and c_custkey = o_custkey     and o_orderkey = l_orderkey group by c_name, c_custkey, o_orderkey, o_orderdate, o_totalprice order by o_totalprice desc, o_orderdate limit 100;
+--------------------+-----------+------------+-------------+--------------+-----------------+
| c_name             | c_custkey | o_orderkey | o_orderdate | o_totalprice | sum(l_quantity) |
+--------------------+-----------+------------+-------------+--------------+-----------------+
| Customer#000128120 |    128120 |    4722021 | 1994-04-07  |    544089.09 |          323.00 |
| Customer#000144617 |    144617 |    3043270 | 1997-02-12  |    530604.44 |          317.00 |
| Customer#000066790 |     66790 |    2199712 | 1996-09-30  |    515531.82 |          327.00 |
| Customer#000015619 |     15619 |    3767271 | 1996-08-07  |    480083.96 |          318.00 |
| Customer#000147197 |    147197 |    1263015 | 1997-02-02  |    467149.67 |          320.00 |
| Customer#000117919 |    117919 |    2869152 | 1996-06-20  |    456815.92 |          317.00 |
| Customer#000126865 |    126865 |    4702759 | 1994-11-07  |    447606.65 |          320.00 |
| Customer#000036619 |     36619 |    4806726 | 1995-01-17  |    446704.09 |          328.00 |
| Customer#000119989 |    119989 |    1544643 | 1997-09-20  |    434568.25 |          320.00 |
+--------------------+-----------+------------+-------------+--------------+-----------------+
9 rows in set (4.24 sec)

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• windtalker
• ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[Lloyd-Pottiger]

/cc @solotzg @windtalker @ywqzzy

[ywqzzy]

A solid bench is needed

[Lloyd-Pottiger]

Running ./dbms/bench_dbms
Run on (40 X 2399.94 MHz CPU s)
CPU Caches:
  L1 Data 32 KiB (x20)
  L1 Instruction 32 KiB (x20)
  L2 Unified 256 KiB (x20)
  L3 Unified 25600 KiB (x2)
Load Average: 48.56, 24.48, 23.63
# before
--------------------------------------------------------------------------------------------------
Benchmark                                                        Time             CPU   Iterations
--------------------------------------------------------------------------------------------------
NumberComparsionBench/constantEqVector/iterations:100        95193 ns        95195 ns          100
NumberComparsionBench/vectorEqVector/iterations:100         112950 ns       112955 ns          100
NumberComparsionBench/constantLessVector/iterations:100     104847 ns       104850 ns          100
NumberComparsionBench/vectorLessVector/iterations:100       112402 ns       112410 ns          100
# after
--------------------------------------------------------------------------------------------------
Benchmark                                                        Time             CPU   Iterations
--------------------------------------------------------------------------------------------------
NumberComparsionBench/constantEqVector/iterations:100        60521 ns        60521 ns          100
NumberComparsionBench/vectorEqVector/iterations:100          63688 ns        63687 ns          100
NumberComparsionBench/constantLessVector/iterations:100      58405 ns        58405 ns          100
NumberComparsionBench/vectorLessVector/iterations:100        64027 ns        64028 ns          100

[Lloyd-Pottiger]

change the row_num = 10000000

# before
--------------------------------------------------------------------------------------------------
Benchmark                                                        Time             CPU   Iterations
--------------------------------------------------------------------------------------------------
NumberComparsionBench/constantEqVector/iterations:100     10734751 ns     10734228 ns          100
NumberComparsionBench/vectorEqVector/iterations:100       19793874 ns     19791053 ns          100
NumberComparsionBench/constantLessVector/iterations:100   11959062 ns     11947725 ns          100
NumberComparsionBench/vectorLessVector/iterations:100     19011253 ns     19001708 ns          100
# after
--------------------------------------------------------------------------------------------------
Benchmark                                                        Time             CPU   Iterations
--------------------------------------------------------------------------------------------------
NumberComparsionBench/constantEqVector/iterations:100      8810097 ns      8810259 ns          100
NumberComparsionBench/vectorEqVector/iterations:100       16357388 ns     16312559 ns          100
NumberComparsionBench/constantLessVector/iterations:100    9277899 ns      9278057 ns          100
NumberComparsionBench/vectorLessVector/iterations:100     15475154 ns     15475493 ns          100

[Lloyd-Pottiger]

/run-all-tests

[sre-bot]

Coverage for changed files

Filename                                                                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Functions/FunctionsComparison.h         600               304    49.33%          63                29    53.97%         929               509    45.21%         472               284    39.83%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                       600               304    49.33%          63                29    53.97%         929               509    45.21%         472               284    39.83%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18384      8350             54.58%    211825  86274        59.27%

full coverage report (for internal network access only)

[Lloyd-Pottiger]

/run-integration-test

[Lloyd-Pottiger]

/run-all-tests

[sre-bot]

Coverage for changed files

Filename                                                                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Functions/FunctionsComparison.h         600               301    49.83%          63                28    55.56%         929               502    45.96%         472               285    39.62%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                       600               301    49.83%          63                28    55.56%         929               502    45.96%         472               285    39.62%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18479      8324             54.95%    213784  85949        59.80%

full coverage report (for internal network access only)

[windtalker]

LGTM

[ywqzzy]

Excellent

[Lloyd-Pottiger]

/merge

[ti-chi-bot]

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: fe5a350

[ti-chi-bot]

@Lloyd-Pottiger: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[sre-bot]

Coverage for changed files

Filename                                                                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Functions/FunctionsComparison.h         600               304    49.33%          63                28    55.56%         929               505    45.64%         472               288    38.98%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                       600               304    49.33%          63                28    55.56%         929               505    45.64%         472               288    38.98%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18475      8322             54.96%    213709  85879        59.81%

full coverage report (for internal network access only)

[Lloyd-Pottiger]

/merge

[ti-chi-bot]

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[sre-bot]

Coverage for changed files

Filename                                                                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Functions/FunctionsComparison.h         600               301    49.83%          63                28    55.56%         929               502    45.96%         472               291    38.35%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                       600               301    49.83%          63                28    55.56%         929               502    45.96%         472               291    38.35%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18475      8321             54.96%    213709  85906        59.80%

full coverage report (for internal network access only)

[Lloyd-Pottiger]

/merge

[ti-chi-bot]

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[Lloyd-Pottiger]

/build

[sre-bot]

Coverage for changed files

Filename                                                                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Functions/FunctionsComparison.h         600               301    49.83%          63                28    55.56%         929               502    45.96%         472               289    38.77%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                       600               301    49.83%          63                28    55.56%         929               502    45.96%         472               289    38.77%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18475      8323             54.95%    213709  85943        59.79%

full coverage report (for internal network access only)

[Lloyd-Pottiger]

/merge

[ti-chi-bot]

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[sre-bot]

Coverage for changed files

Filename                                                                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Functions/FunctionsComparison.h         600               301    49.83%          63                28    55.56%         929               502    45.96%         472               284    39.83%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                       600               301    49.83%          63                28    55.56%         929               502    45.96%         472               284    39.83%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18475      8321             54.96%    213709  85908        59.80%

full coverage report (for internal network access only)

[Lloyd-Pottiger]

/hold

[Lloyd-Pottiger]

merge into #5748