-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix large write cause tiflash crash (release-6.5) #7345
Fix large write cause tiflash crash (release-6.5) #7345
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
f8842c8
to
aa30cfe
Compare
/run-all-tests |
/run-all-tests |
/run-integration-test |
f77e273
to
61cec2d
Compare
/run-all-tests |
/merge |
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 61cec2d
|
/cherry-pick release-6.5-20230425-v6.5.2 |
@JaySon-Huang: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Manual cherry-pick of #7335
What problem does this PR solve?
Issue Number: close #7316
Problem Summary:
The root cause is
BlobStore<Trait>::handleLargeWrite
get a buffer fromMemoryWriteBuffer
and access the memory bywrite.size
, which exceed the memory bound.MemoryWriteBuffer
actually is composed by a list ofchunk
stiflash/dbms/src/Storages/Page/V3/BlobStore.cpp
Lines 190 to 216 in b2b976e
What is changed and how it works?
The write batch data size is large, we do NOT copy the data into a temporary buffer in order to make the memory usage of tiflash more smooth. Instead, we process the data in ReadBuffer in a streaming manner.
Check List
Tests
Side effects
Documentation
Release note