Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support last_value window function #7433

Merged
merged 10 commits into from
May 16, 2023
Merged

Support last_value window function #7433

merged 10 commits into from
May 16, 2023

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #7376

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 7, 2023
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker @SeaRise

@ti-chi-bot ti-chi-bot bot requested review from SeaRise and windtalker May 7, 2023 03:02
SeaRise
SeaRise reviewed May 8, 2023
View reviewed changes
dbms/src/WindowFunctions/IWindowFunction.cpp Outdated
to.insert(value_field);
}

void processFrameTypeUnbounded(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that all cases can be handled by this function, no need to distinguish which frame type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that all cases can be handled by this function, no need to distinguish which frame type.

Sry, it's a bad name and the function will be renamed to processBoundryTypeUnbounded.

@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker @SeaRise

@ti-chi-bot ti-chi-bot bot requested a review from SeaRise May 10, 2023 06:11
@SeaRise SeaRise self-requested a review May 12, 2023 06:21
SeaRise
SeaRise approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 12, 2023
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker

windtalker
windtalker approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 15, 2023
@xzhangxian1008
Copy link
Contributor Author

/run-all-tests

@xzhangxian1008
Copy link
Contributor Author

/run-all-tests

@xzhangxian1008
Copy link
Contributor Author

/run-unit-test

1 similar comment
@xzhangxian1008
Copy link
Contributor Author

/run-unit-test

@ywqzzy
Copy link
Contributor

ywqzzy commented May 16, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2023

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: dfcd37d

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 16, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2023
@ti-chi-bot ti-chi-bot bot removed status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 16, 2023
@gengliqi
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2023

@gengliqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 6d1d366

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 16, 2023
@ti-chi-bot ti-chi-bot bot merged commit bd12de3 into pingcap:master May 16, 2023
@xzhangxian1008 xzhangxian1008 deleted the last_val branch May 16, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xzhangxian1008 @ywqzzy @gengliqi @windtalker @SeaRise