Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tsan: fix data race on ComputeServerRunner.cancelJoinTasks (#7434) #8729

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7434

What problem does this PR solve?

Issue Number: close #7432

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jan 24, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 24, 2024
@ywqzzy
Copy link
Contributor

ywqzzy commented Jan 24, 2024

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-24 05:03:12.595404014 +0000 UTC m=+937034.159701719: ☑️ agreed by SeaRise.
  • 2024-01-24 05:06:54.360921624 +0000 UTC m=+937255.925219329: ☑️ agreed by ywqzzy.

@SeaRise
Copy link
Contributor

SeaRise commented Jan 24, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 24, 2024
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-7434-to-release-7.1 branch from 021dde0 to 238ca5b Compare January 24, 2024 05:09
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-7434-to-release-7.1 branch from 238ca5b to c2e6411 Compare January 24, 2024 05:10
@SeaRise
Copy link
Contributor

SeaRise commented Jan 24, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 9e5b582 into pingcap:release-7.1 Jan 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants