Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup OWNERS files in top folders #11100

Closed
1 task done
wuhuizuo opened this issue May 15, 2024 · 2 comments · Fixed by #11101
Closed
1 task done

Setup OWNERS files in top folders #11100

wuhuizuo opened this issue May 15, 2024 · 2 comments · Fixed by #11101
Assignees
@wuhuizuo
Labels
question Further information is requested. type/enhancement The issue or PR belongs to an enhancement.

Comments

@wuhuizuo
Copy link
Contributor

wuhuizuo commented May 15, 2024 •
edited
Loading

Proposal

Enhancement

Setup OWNERS files in top folders and add experts as module approvers, we will brings advantages:

  • Make assigning be appropriate and reviewing be efficient.

Ref:

Tasks

  • add OWNERS file for DM and engine modules.
@wuhuizuo wuhuizuo added the question Further information is requested. label May 15, 2024
@wuhuizuo
Copy link
Contributor Author

/type enhancement

@ti-chi-bot ti-chi-bot bot added the type/enhancement The issue or PR belongs to an enhancement. label May 15, 2024
@wuhuizuo
Copy link
Contributor Author

/assign wuhuizuo

@wuhuizuo wuhuizuo mentioned this issue May 15, 2024
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in 2d5d1c3 May 15, 2024
This was referenced May 15, 2024
Open
Merged
Open
Open
ti-chi-bot bot pushed a commit that referenced this issue May 17, 2024
@ti-chi-bot
ci: add prow OWNERS for dm and engine modules (#11101) (#11105)
6e86ce5 
close #11100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wuhuizuo wuhuizuo

Labels
question Further information is requested. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add prow OWNERS for dm and engine modules wuhuizuo/tiflow
1 participant
@wuhuizuo