Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiflow depends on packages in LGPL-3.0 #11199

Closed
hicqu opened this issue May 30, 2024 · 0 comments · Fixed by #11193 or #11204
Closed

Tiflow depends on packages in LGPL-3.0 #11199

hicqu opened this issue May 30, 2024 · 0 comments · Fixed by #11193 or #11204
Labels
affects-7.5 affects-8.1 area/ticdc Issues or PRs related to TiCDC. severity/critical type/enhancement The issue or PR belongs to an enhancement.

Comments

@hicqu
Copy link
Contributor

hicqu commented May 30, 2024

What did you do?

Tiflow depends on blainsmith.com/go/seahash, and blainsmith.com/go/seahash depends on some other packages in LGPL-3.0.

What did you expect to see?

No response

What did you see instead?

We need to remove those dependencies.

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

(paste TiCDC version here)
@hicqu hicqu added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. labels May 30, 2024
@hicqu hicqu added type/enhancement The issue or PR belongs to an enhancement. affects-7.5 affects-8.1 and removed type/bug The issue is confirmed as a bug. labels May 30, 2024
@hicqu hicqu mentioned this issue May 30, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue May 30, 2024
@hicqu
*: copy seahash from blainsmith.com/go/seahash (#11193)
7fbae79 
close #11199
This was referenced May 30, 2024
Merged
Merged
@hicqu hicqu mentioned this issue May 30, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue May 30, 2024
@ti-chi-bot
*: copy seahash from blainsmith.com/go/seahash (#11193) (#11200)
3625884 
close #11199
ti-chi-bot bot pushed a commit that referenced this issue May 30, 2024
@hicqu
*: tidy go mod (#11204)
350a2fb 
close #11199
This was referenced May 30, 2024
Closed
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jul 30, 2024
@ti-chi-bot
*: copy seahash from blainsmith.com/go/seahash (#11193) (#11201)
07c67ec 
close #11199
ti-chi-bot bot pushed a commit that referenced this issue Jul 31, 2024
@ti-chi-bot
*: tidy go mod (#11204) (#11209)
126e30b 
close #11199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.5 affects-8.1 area/ticdc Issues or PRs related to TiCDC. severity/critical type/enhancement The issue or PR belongs to an enhancement.
Projects
Question and Bug Reports
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: copy seahash from blainsmith.com/go/seahash hicqu/ticdc
*: tidy go mod hicqu/ticdc
2 participants
@flowbehappy @hicqu